From: Freddy Xin <[email protected]>
Add VID:DID for Lenovo OneLinkDock Gigabit LAN
Signed-off-by: Freddy Xin <[email protected]>
---
drivers/net/usb/ax88179_178a.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 955df81..460e823 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1421,6 +1421,19 @@ static const struct driver_info samsung_info = {
.tx_fixup = ax88179_tx_fixup,
};
+static const struct driver_info lenovo_info = {
+ .description = "Lenovo OneLinkDock Gigabit LAN",
+ .bind = ax88179_bind,
+ .unbind = ax88179_unbind,
+ .status = ax88179_status,
+ .link_reset = ax88179_link_reset,
+ .reset = ax88179_reset,
+ .stop = ax88179_stop,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
+ .rx_fixup = ax88179_rx_fixup,
+ .tx_fixup = ax88179_tx_fixup,
+};
+
static const struct usb_device_id products[] = {
{
/* ASIX AX88179 10/100/1000 */
@@ -1438,6 +1451,10 @@ static const struct usb_device_id products[] = {
/* Samsung USB Ethernet Adapter */
USB_DEVICE(0x04e8, 0xa100),
.driver_info = (unsigned long)&samsung_info,
+}, {
+ /* Lenovo OneLinkDock Gigabit LAN */
+ USB_DEVICE(0x17ef, 0x304b),
+ .driver_info = (unsigned long)&lenovo_info,
},
{ },
};
--
1.7.10.4
[email protected] writes:
> From: Freddy Xin <[email protected]>
>
> Add VID:DID for Lenovo OneLinkDock Gigabit LAN
This is the same patch Keith Packard sent, but with a slighly different
description. I take that as another proof that we should not attempt to
describe devices in these drivers. Describe the driver instead.
Bjørn
From: Bj?rn Mork <[email protected]>
Date: Wed, 26 Feb 2014 13:13:12 +0100
> [email protected] writes:
>
>> From: Freddy Xin <[email protected]>
>>
>> Add VID:DID for Lenovo OneLinkDock Gigabit LAN
>
> This is the same patch Keith Packard sent, but with a slighly different
> description. I take that as another proof that we should not attempt to
> describe devices in these drivers. Describe the driver instead.
Are you saying that this patch needs to be implemented differently?
David Miller <[email protected]> writes:
> From: Bjørn Mork <[email protected]>
> Date: Wed, 26 Feb 2014 13:13:12 +0100
>
>> [email protected] writes:
>>
>>> From: Freddy Xin <[email protected]>
>>>
>>> Add VID:DID for Lenovo OneLinkDock Gigabit LAN
>>
>> This is the same patch Keith Packard sent, but with a slighly different
>> description. I take that as another proof that we should not attempt to
>> describe devices in these drivers. Describe the driver instead.
>
> Are you saying that this patch needs to be implemented differently?
No, sorry for being confusing. The patch is fine. But Keith sent it
first...
The other comment is more of a personal opinion on the driver style. In
any case, it's something that can be fixed up later. If at all.
Bjørn
From: Bj?rn Mork <[email protected]>
Date: Wed, 26 Feb 2014 22:14:10 +0100
> David Miller <[email protected]> writes:
>
>> From: Bj?rn Mork <[email protected]>
>> Date: Wed, 26 Feb 2014 13:13:12 +0100
>>
>>> [email protected] writes:
>>>
>>>> From: Freddy Xin <[email protected]>
>>>>
>>>> Add VID:DID for Lenovo OneLinkDock Gigabit LAN
>>>
>>> This is the same patch Keith Packard sent, but with a slighly different
>>> description. I take that as another proof that we should not attempt to
>>> describe devices in these drivers. Describe the driver instead.
>>
>> Are you saying that this patch needs to be implemented differently?
>
> No, sorry for being confusing. The patch is fine. But Keith sent it
> first...
Did I apply Keith's patch? If not, should I apply it instead?
David Miller <[email protected]> writes:
> From: Bjørn Mork <[email protected]>
>
>> No, sorry for being confusing. The patch is fine. But Keith sent it
>> first...
>
> Did I apply Keith's patch?
No, you didn't. And when I went looking at it now, I see why: It was
posted to linux-usb and linux-kernel but not to netdev:
http://www.kernelhub.org/?msg=420289&p=2
> If not, should I apply it instead?
The patches are identical except for the author and a minor difference
in the device description string.
It doesn't matter to me which patch you apply, and I absolutely don't
think it's my place to tell you which patches to apply or not :-)
Bjørn
From: Bj?rn Mork <[email protected]>
Date: Wed, 26 Feb 2014 22:44:18 +0100
> David Miller <[email protected]> writes:
>> From: Bj?rn Mork <[email protected]>
>>
>>> No, sorry for being confusing. The patch is fine. But Keith sent it
>>> first...
>>
>> Did I apply Keith's patch?
>
> No, you didn't. And when I went looking at it now, I see why: It was
> posted to linux-usb and linux-kernel but not to netdev:
> http://www.kernelhub.org/?msg=420289&p=2
>
>> If not, should I apply it instead?
>
> The patches are identical except for the author and a minor difference
> in the device description string.
>
> It doesn't matter to me which patch you apply, and I absolutely don't
> think it's my place to tell you which patches to apply or not :-)
Fair enough, I'll apply this one, thanks!
Bjørn Mork <[email protected]> writes:
> No, you didn't. And when I went looking at it now, I see why: It was
> posted to linux-usb and linux-kernel but not to netdev:
> http://www.kernelhub.org/?msg=420289&p=2
I looked in MAINTAINERS and found linux-usb as a suitable address for
drivers/net/usb/. I'm sorry I didn't think to look for drivers/net/ as
well.
> It doesn't matter to me which patch you apply, and I absolutely don't
> think it's my place to tell you which patches to apply or not :-)
Doesn't matter to me either; just want to make sure the device works.
--
[email protected]
On Wed, 2014-02-26 at 14:23 -0800, Keith Packard wrote:
> Bj?rn Mork <[email protected]> writes:
>
> > No, you didn't. And when I went looking at it now, I see why: It was
> > posted to linux-usb and linux-kernel but not to netdev:
> > http://www.kernelhub.org/?msg=420289&p=2
>
> I looked in MAINTAINERS and found linux-usb as a suitable address for
> drivers/net/usb/. I'm sorry I didn't think to look for drivers/net/ as
> well.
Hi Keith.
You could use scripts/get_maintainer.pl next time.
$ ./scripts/get_maintainer.pl -f drivers/net/usb/ax88179_178a.c
"David S. Miller" <[email protected]> (commit_signer:13/13=100%)
Freddy Xin <[email protected]> (commit_signer:4/13=31%,authored:4/13=31%,added_lines:1473/1504=98%,removed_lines:9/43=21%)
Eric Dumazet <[email protected]> (commit_signer:3/13=23%,authored:2/13=15%,removed_lines:22/43=51%)
Ming Lei <[email protected]> (commit_signer:3/13=23%,authored:3/13=23%,removed_lines:8/43=19%)
David Chang <[email protected]> (commit_signer:2/13=15%,authored:2/13=15%)
Emil Goode <[email protected]> (authored:1/13=8%)
[email protected] (open list:USB NETWORKING DR...)
[email protected] (open list:NETWORKING DRIVERS)
[email protected] (open list)
Maybe there should be a MAINTAINERS entry added too?
Joe Perches <[email protected]> writes:
> You could use scripts/get_maintainer.pl next time.
Yeah, good point. I always forget about that tool when I'm hacking
outside my normal areas.
--
[email protected]