2021-09-14 14:36:50

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v2 14/29] ABI: sysfs-bus-pci: use wildcards on What definitions

An "N" upper letter is not a wildcard, nor can easily be identified
by script, specially since the USB sysfs define things like.
bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl
to convert it into a Regex.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
Documentation/ABI/testing/sysfs-bus-pci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci
index d4ae03296861..191cbe9ae5ed 100644
--- a/Documentation/ABI/testing/sysfs-bus-pci
+++ b/Documentation/ABI/testing/sysfs-bus-pci
@@ -160,7 +160,7 @@ Description:
If the underlying VPD has a writable section then the
corresponding section of this file will be writable.

-What: /sys/bus/pci/devices/.../virtfnN
+What: /sys/bus/pci/devices/.../virtfn<N>
Date: March 2009
Contact: Yu Zhao <[email protected]>
Description:
--
2.31.1


2021-09-14 18:58:39

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH v2 14/29] ABI: sysfs-bus-pci: use wildcards on What definitions

On Tue, Sep 14, 2021 at 04:32:29PM +0200, Mauro Carvalho Chehab wrote:
> An "N" upper letter is not a wildcard, nor can easily be identified
> by script, specially since the USB sysfs define things like.
> bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl
> to convert it into a Regex.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Acked-by: Bjorn Helgaas <[email protected]>

> ---
> Documentation/ABI/testing/sysfs-bus-pci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci
> index d4ae03296861..191cbe9ae5ed 100644
> --- a/Documentation/ABI/testing/sysfs-bus-pci
> +++ b/Documentation/ABI/testing/sysfs-bus-pci
> @@ -160,7 +160,7 @@ Description:
> If the underlying VPD has a writable section then the
> corresponding section of this file will be writable.
>
> -What: /sys/bus/pci/devices/.../virtfnN
> +What: /sys/bus/pci/devices/.../virtfn<N>
> Date: March 2009
> Contact: Yu Zhao <[email protected]>
> Description:
> --
> 2.31.1
>