2018-10-04 21:09:34

by René Kjellerup

[permalink] [raw]
Subject: Adding a Basic DT for the Linksys ea6500 v2 wireless home router

Hi Hauke,

thank you for suggesting adding the dts patch to mainline kernel,
so here it is.
I feel Rafal technically still have the copyrights, this is pretty
much just a few string updates for the ea6500v2. However with this
dts in latest OpenWrt 18.06 loads and installs on my device.

I will be available to do more testing should it be required.

Regrads
Rene Kjellerup
--
-- as life grows older, I gain experience.
-- http://www.alchemiestick.net/


Attachments:
0001-ARM-dts-BCM5301X-Add-basic-DT-for-Linksys-EA6500-V2.patch (2.21 kB)

2018-10-07 21:09:00

by Hauke Mehrtens

[permalink] [raw]
Subject: Re: Adding a Basic DT for the Linksys ea6500 v2 wireless home router

On 10/04/2018 11:08 PM, René Kjellerup wrote:
> Hi Hauke,
>
> thank you for suggesting adding the dts patch to mainline kernel,
> so here it is.
> I feel Rafal technically still have the copyrights, this is pretty
> much just a few string updates for the ea6500v2. However with this
> dts in latest OpenWrt 18.06 loads and installs on my device.
>
> I will be available to do more testing should it be required.
>
> Regrads
> Rene Kjellerup
> --
> -- as life grows older, I gain experience.
> -- http://www.alchemiestick.net/
>

Hi Rene,

Please send you patch inline in the mail and not as an attachment, I
would suggest to use "git send-email" for sending the patch.

Adding Rafal as copyright owner is ok, like you did it now. You could
mention in the file header on which dts file this is based.

Hauke


Attachments:
signature.asc (499.00 B)
OpenPGP digital signature

2018-10-08 16:35:26

by René Kjellerup

[permalink] [raw]
Subject: Re: Adding a Basic DT for the Linksys ea6500 v2 wireless home router

Hi Hauke,

Updated the file header per your suggestion.

From e97c15ef78d2535c23f32ebbec43bced72b5eaf7 Mon Sep 17 00:00:00 2001
From: Rene Kjellerup <[email protected]>
Date: Mon, 1 Oct 2018 14:11:56 -0700
Subject: [PATCH] ARM: dts: BCM5301X: Add basic DT for Linksys EA6500 V2

It's wireless home router based on BCM4708A0 with BCM4360 + BCM4331
wireless chipsets. The 5GHz chip currently isn't supported only due
to missing compatible firmware.

the DTS here was based on the Linksys EA6300 V1 DTS, only changing
the model strings

Signed-off-by: Rene Kjellerup <[email protected]>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts | 47 +++++++++++++++++++++++++
2 files changed, 48 insertions(+)
create mode 100644 arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index b5bd3de87c33..adf8f28f5e44 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -88,6 +88,7 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \
bcm4708-asus-rt-ac68u.dtb \
bcm4708-buffalo-wzr-1750dhp.dtb \
bcm4708-linksys-ea6300-v1.dtb \
+ bcm4708-linksys-ea6500-v2.dtb \
bcm4708-luxul-xap-1510.dtb \
bcm4708-luxul-xwc-1000.dtb \
bcm4708-netgear-r6250.dtb \
diff --git a/arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
b/arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
new file mode 100644
index 000000000000..8a434d2a4b72
--- /dev/null
+++ b/arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
@@ -0,0 +1,47 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright (C) 2017 Rafał Miłecki <[email protected]>
+ * Copyright (C) 2018 Rene Kjellerup <[email protected]>
+ *
+ * this DTS was originally based on bcm4708-linksys-ea6300-v1.dts
+ */
+
+/dts-v1/;
+
+#include "bcm4708.dtsi"
+#include "bcm5301x-nand-cs0-bch8.dtsi"
+
+/ {
+ compatible = "linksys,ea6500-v2", "brcm,bcm4708";
+ model = "Linksys EA6500 V2";
+
+ chosen {
+ bootargs = "console=ttyS0,115200";
+ };
+
+ memory {
+ reg = <0x00000000 0x08000000>;
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ wps {
+ label = "WPS";
+ linux,code = <KEY_WPS_BUTTON>;
+ gpios = <&chipcommon 7 GPIO_ACTIVE_LOW>;
+ };
+
+ restart {
+ label = "Reset";
+ linux,code = <KEY_RESTART>;
+ gpios = <&chipcommon 11 GPIO_ACTIVE_LOW>;
+ };
+ };
+};
+
+&usb3_phy {
+ status = "okay";
+};
--
2.16.4

On Sun, Oct 7, 2018 at 2:08 PM Hauke Mehrtens <[email protected]> wrote:
>
> On 10/04/2018 11:08 PM, René Kjellerup wrote:
> > Hi Hauke,
> >
> > thank you for suggesting adding the dts patch to mainline kernel,
> > so here it is.
> > I feel Rafal technically still have the copyrights, this is pretty
> > much just a few string updates for the ea6500v2. However with this
> > dts in latest OpenWrt 18.06 loads and installs on my device.
> >
> > I will be available to do more testing should it be required.
> >
> > Regrads
> > Rene Kjellerup
> > --
> > -- as life grows older, I gain experience.
> > -- http://www.alchemiestick.net/
> >
>
> Hi Rene,
>
> Please send you patch inline in the mail and not as an attachment, I
> would suggest to use "git send-email" for sending the patch.
>
> Adding Rafal as copyright owner is ok, like you did it now. You could
> mention in the file header on which dts file this is based.
>
> Hauke
>


--
-- as life grows older, I gain experience.
-- http://www.alchemiestick.net/apps/

2018-11-27 00:50:34

by René Kjellerup

[permalink] [raw]
Subject: Re: Adding a Basic DT for the Linksys ea6500 v2 wireless home router

To the broadcom kernel maintainers, (for BCM4708 CPUs)

I just want to add a little attention to this patch again...
let me know if there's any concerns and I will try to address highlighted issues
as soon as possible.

I've been running the development builds of OpenWrt kernels, where
this patch has
been included, on my Linksys EA6500v2 router for the past months,
updating as new
builds are available. With only the on board BCM4360 chip (5GHz WiFi) is being
disabled, has so far been stable for my use case.

thank you for the consideration
Rene (aka Katana_Steel)

On Mon, Oct 8, 2018 at 9:34 AM René Kjellerup <[email protected]> wrote:
>
> Hi Hauke,
>
> Updated the file header per your suggestion.
>
> From e97c15ef78d2535c23f32ebbec43bced72b5eaf7 Mon Sep 17 00:00:00 2001
> From: Rene Kjellerup <[email protected]>
> Date: Mon, 1 Oct 2018 14:11:56 -0700
> Subject: [PATCH] ARM: dts: BCM5301X: Add basic DT for Linksys EA6500 V2
>
> It's wireless home router based on BCM4708A0 with BCM4360 + BCM4331
> wireless chipsets. The 5GHz chip currently isn't supported only due
> to missing compatible firmware.
>
> the DTS here was based on the Linksys EA6300 V1 DTS, only changing
> the model strings
>
> Signed-off-by: Rene Kjellerup <[email protected]>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts | 47 +++++++++++++++++++++++++
> 2 files changed, 48 insertions(+)
> create mode 100644 arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b5bd3de87c33..adf8f28f5e44 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -88,6 +88,7 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \
> bcm4708-asus-rt-ac68u.dtb \
> bcm4708-buffalo-wzr-1750dhp.dtb \
> bcm4708-linksys-ea6300-v1.dtb \
> + bcm4708-linksys-ea6500-v2.dtb \
> bcm4708-luxul-xap-1510.dtb \
> bcm4708-luxul-xwc-1000.dtb \
> bcm4708-netgear-r6250.dtb \
> diff --git a/arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
> b/arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
> new file mode 100644
> index 000000000000..8a434d2a4b72
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
> @@ -0,0 +1,47 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (C) 2017 Rafał Miłecki <[email protected]>
> + * Copyright (C) 2018 Rene Kjellerup <[email protected]>
> + *
> + * this DTS was originally based on bcm4708-linksys-ea6300-v1.dts
> + */
> +
> +/dts-v1/;
> +
> +#include "bcm4708.dtsi"
> +#include "bcm5301x-nand-cs0-bch8.dtsi"
> +
> +/ {
> + compatible = "linksys,ea6500-v2", "brcm,bcm4708";
> + model = "Linksys EA6500 V2";
> +
> + chosen {
> + bootargs = "console=ttyS0,115200";
> + };
> +
> + memory {
> + reg = <0x00000000 0x08000000>;
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + wps {
> + label = "WPS";
> + linux,code = <KEY_WPS_BUTTON>;
> + gpios = <&chipcommon 7 GPIO_ACTIVE_LOW>;
> + };
> +
> + restart {
> + label = "Reset";
> + linux,code = <KEY_RESTART>;
> + gpios = <&chipcommon 11 GPIO_ACTIVE_LOW>;
> + };
> + };
> +};
> +
> +&usb3_phy {
> + status = "okay";
> +};
> --
> 2.16.4
>
> On Sun, Oct 7, 2018 at 2:08 PM Hauke Mehrtens <[email protected]> wrote:
> >
> > On 10/04/2018 11:08 PM, René Kjellerup wrote:
> > > Hi Hauke,
> > >
> > > thank you for suggesting adding the dts patch to mainline kernel,
> > > so here it is.
> > > I feel Rafal technically still have the copyrights, this is pretty
> > > much just a few string updates for the ea6500v2. However with this
> > > dts in latest OpenWrt 18.06 loads and installs on my device.
> > >
> > > I will be available to do more testing should it be required.
> > >
> > > Regrads
> > > Rene Kjellerup
> > > --
> > > -- as life grows older, I gain experience.
> > > -- http://www.alchemiestick.net/
> > >
> >
> > Hi Rene,
> >
> > Please send you patch inline in the mail and not as an attachment, I
> > would suggest to use "git send-email" for sending the patch.
> >
> > Adding Rafal as copyright owner is ok, like you did it now. You could
> > mention in the file header on which dts file this is based.
> >
> > Hauke
> >
>
>
> --
> -- as life grows older, I gain experience.
> -- http://www.alchemiestick.net/apps/

2018-11-28 00:24:11

by Florian Fainelli

[permalink] [raw]
Subject: Re: Adding a Basic DT for the Linksys ea6500 v2 wireless home router



On 11/26/18 4:49 PM, René Kjellerup wrote:
> To the broadcom kernel maintainers, (for BCM4708 CPUs)
>
> I just want to add a little attention to this patch again...
> let me know if there's any concerns and I will try to address highlighted issues
> as soon as possible.
>
> I've been running the development builds of OpenWrt kernels, where
> this patch has
> been included, on my Linksys EA6500v2 router for the past months,
> updating as new
> builds are available. With only the on board BCM4360 chip (5GHz WiFi) is being
> disabled, has so far been stable for my use case.

(Please no top posting). Your submission did make it through patchwork
and looks okay, I will run build tests and queue it up for 4.21 if
everything looks good. Thanks.

>
> thank you for the consideration
> Rene (aka Katana_Steel)
>
> On Mon, Oct 8, 2018 at 9:34 AM René Kjellerup <[email protected]> wrote:
>>
>> Hi Hauke,
>>
>> Updated the file header per your suggestion.
>>
>> From e97c15ef78d2535c23f32ebbec43bced72b5eaf7 Mon Sep 17 00:00:00 2001
>> From: Rene Kjellerup <[email protected]>
>> Date: Mon, 1 Oct 2018 14:11:56 -0700
>> Subject: [PATCH] ARM: dts: BCM5301X: Add basic DT for Linksys EA6500 V2
>>
>> It's wireless home router based on BCM4708A0 with BCM4360 + BCM4331
>> wireless chipsets. The 5GHz chip currently isn't supported only due
>> to missing compatible firmware.
>>
>> the DTS here was based on the Linksys EA6300 V1 DTS, only changing
>> the model strings
>>
>> Signed-off-by: Rene Kjellerup <[email protected]>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts | 47 +++++++++++++++++++++++++
>> 2 files changed, 48 insertions(+)
>> create mode 100644 arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index b5bd3de87c33..adf8f28f5e44 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -88,6 +88,7 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \
>> bcm4708-asus-rt-ac68u.dtb \
>> bcm4708-buffalo-wzr-1750dhp.dtb \
>> bcm4708-linksys-ea6300-v1.dtb \
>> + bcm4708-linksys-ea6500-v2.dtb \
>> bcm4708-luxul-xap-1510.dtb \
>> bcm4708-luxul-xwc-1000.dtb \
>> bcm4708-netgear-r6250.dtb \
>> diff --git a/arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
>> b/arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
>> new file mode 100644
>> index 000000000000..8a434d2a4b72
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/bcm4708-linksys-ea6500-v2.dts
>> @@ -0,0 +1,47 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
>> +/*
>> + * Copyright (C) 2017 Rafał Miłecki <[email protected]>
>> + * Copyright (C) 2018 Rene Kjellerup <[email protected]>
>> + *
>> + * this DTS was originally based on bcm4708-linksys-ea6300-v1.dts
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "bcm4708.dtsi"
>> +#include "bcm5301x-nand-cs0-bch8.dtsi"
>> +
>> +/ {
>> + compatible = "linksys,ea6500-v2", "brcm,bcm4708";
>> + model = "Linksys EA6500 V2";
>> +
>> + chosen {
>> + bootargs = "console=ttyS0,115200";
>> + };
>> +
>> + memory {
>> + reg = <0x00000000 0x08000000>;
>> + };
>> +
>> + gpio-keys {
>> + compatible = "gpio-keys";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + wps {
>> + label = "WPS";
>> + linux,code = <KEY_WPS_BUTTON>;
>> + gpios = <&chipcommon 7 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + restart {
>> + label = "Reset";
>> + linux,code = <KEY_RESTART>;
>> + gpios = <&chipcommon 11 GPIO_ACTIVE_LOW>;
>> + };
>> + };
>> +};
>> +
>> +&usb3_phy {
>> + status = "okay";
>> +};
>> --
>> 2.16.4
>>
>> On Sun, Oct 7, 2018 at 2:08 PM Hauke Mehrtens <[email protected]> wrote:
>>>
>>> On 10/04/2018 11:08 PM, René Kjellerup wrote:
>>>> Hi Hauke,
>>>>
>>>> thank you for suggesting adding the dts patch to mainline kernel,
>>>> so here it is.
>>>> I feel Rafal technically still have the copyrights, this is pretty
>>>> much just a few string updates for the ea6500v2. However with this
>>>> dts in latest OpenWrt 18.06 loads and installs on my device.
>>>>
>>>> I will be available to do more testing should it be required.
>>>>
>>>> Regrads
>>>> Rene Kjellerup
>>>> --
>>>> -- as life grows older, I gain experience.
>>>> -- http://www.alchemiestick.net/
>>>>
>>>
>>> Hi Rene,
>>>
>>> Please send you patch inline in the mail and not as an attachment, I
>>> would suggest to use "git send-email" for sending the patch.
>>>
>>> Adding Rafal as copyright owner is ok, like you did it now. You could
>>> mention in the file header on which dts file this is based.
>>>
>>> Hauke
>>>
>>
>>
>> --
>> -- as life grows older, I gain experience.
>> -- http://www.alchemiestick.net/apps/

--
Florian

2018-11-30 18:39:06

by Florian Fainelli

[permalink] [raw]
Subject: Re: Adding a Basic DT for the Linksys ea6500 v2 wireless home router

On 11/27/18 6:09 PM, René Kjellerup wrote:
>
> On Tue, Nov 27, 2018 at 4:23 PM Florian Fainelli <[email protected]
> <mailto:[email protected]>> wrote:
>>
>>
>>
>> On 11/26/18 4:49 PM, René Kjellerup wrote:
>> > To the broadcom kernel maintainers, (for BCM4708 CPUs)
>> >
>> > I just want to add a little attention to this patch again...
>> > let me know if there's any concerns and I will try to address
> highlighted issues
>> > as soon as possible.
>> >
>> > I've been running the development builds of OpenWrt kernels, where
>> > this patch has
>> > been included, on my Linksys EA6500v2 router for the past months,
>> > updating as new
>> > builds are available. With only the on board BCM4360 chip (5GHz
> WiFi) is being
>> > disabled, has so far been stable for my use case.
>>
>> (Please no top posting). Your submission did make it through patchwork
>> and looks okay, I will run build tests and queue it up for 4.21 if
>> everything looks good. Thanks.
>>
> ...
>>
>> --
>> Florian
>
> thank you Florian for the update
> I appreciate the feedback

Now applied to devicetree/next, thanks. Please use git
format-patch/send-email in the future, as the patch was mangled a little
bit by being sent within the message body.

Thank you
--
Florian