2019-05-10 04:05:33

by Yue Haibing

Subject: [PATCH] arm64: arch_k3: Fix kconfig dependency warning

Fix Kbuild warning when SOC_TI is not set

WARNING: unmet direct dependencies detected for TI_SCI_INTA_IRQCHIP
Depends on [n]: TI_SCI_PROTOCOL [=y] && SOC_TI [=n]
Selected by [y]:
- ARCH_K3 [=y]

Fixes: 009669e74813 ("arm64: arch_k3: Enable interrupt controller drivers")
Signed-off-by: YueHaibing <[email protected]>
---
arch/arm64/Kconfig.platforms | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 42eca65..9d1292f 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -88,6 +88,7 @@ config ARCH_K3
bool "Texas Instruments Inc. K3 multicore SoC architecture"
select PM_GENERIC_DOMAINS if PM
select MAILBOX
+ select SOC_TI
select TI_MESSAGE_MANAGER
select TI_SCI_PROTOCOL
select TI_SCI_INTR_IRQCHIP
--
2.7.4

2019-05-10 05:29:58

by Lokesh Vutla

Subject: Re: [PATCH] arm64: arch_k3: Fix kconfig dependency warning

On 10/05/19 9:22 AM, YueHaibing wrote:
> Fix Kbuild warning when SOC_TI is not set
>
> WARNING: unmet direct dependencies detected for TI_SCI_INTA_IRQCHIP
> Depends on [n]: TI_SCI_PROTOCOL [=y] && SOC_TI [=n]
> Selected by [y]:
> - ARCH_K3 [=y]
>
> Fixes: 009669e74813 ("arm64: arch_k3: Enable interrupt controller drivers")
> Signed-off-by: YueHaibing <[email protected]>

Thanks for catching it.

Reviewed-by: Lokesh Vutla <[email protected]>

Thanks and regards,
Lokesh

> ---
> arch/arm64/Kconfig.platforms | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 42eca65..9d1292f 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -88,6 +88,7 @@ config ARCH_K3
> bool "Texas Instruments Inc. K3 multicore SoC architecture"
> select PM_GENERIC_DOMAINS if PM
> select MAILBOX
> + select SOC_TI
> select TI_MESSAGE_MANAGER
> select TI_SCI_PROTOCOL
> select TI_SCI_INTR_IRQCHIP
>

2019-05-10 18:31:22

by Marc Zyngier

Subject: Re: [PATCH] arm64: arch_k3: Fix kconfig dependency warning

On Fri, 10 May 2019 06:16:38 +0100,
Lokesh Vutla <[email protected]> wrote:
>
>
>
> On 10/05/19 9:22 AM, YueHaibing wrote:
> > Fix Kbuild warning when SOC_TI is not set
> >
> > WARNING: unmet direct dependencies detected for TI_SCI_INTA_IRQCHIP
> > Depends on [n]: TI_SCI_PROTOCOL [=y] && SOC_TI [=n]
> > Selected by [y]:
> > - ARCH_K3 [=y]
> >
> > Fixes: 009669e74813 ("arm64: arch_k3: Enable interrupt controller drivers")
> > Signed-off-by: YueHaibing <[email protected]>
>
> Thanks for catching it.
>
> Reviewed-by: Lokesh Vutla <[email protected]>

Tony, can you please route this patch via armsoc?

Thanks,

M.

--
Jazz is not dead, it just smell funny.

2019-05-10 21:41:17

by Tony Lindgren

Subject: Re: [PATCH] arm64: arch_k3: Fix kconfig dependency warning

* Marc Zyngier <[email protected]> [190510 18:30]:
> On Fri, 10 May 2019 06:16:38 +0100,
> Lokesh Vutla <[email protected]> wrote:
> >
> >
> >
> > On 10/05/19 9:22 AM, YueHaibing wrote:
> > > Fix Kbuild warning when SOC_TI is not set
> > >
> > > WARNING: unmet direct dependencies detected for TI_SCI_INTA_IRQCHIP
> > > Depends on [n]: TI_SCI_PROTOCOL [=y] && SOC_TI [=n]
> > > Selected by [y]:
> > > - ARCH_K3 [=y]
> > >
> > > Fixes: 009669e74813 ("arm64: arch_k3: Enable interrupt controller drivers")
> > > Signed-off-by: YueHaibing <[email protected]>
> >
> > Thanks for catching it.
> >
> > Reviewed-by: Lokesh Vutla <[email protected]>
>
> Tony, can you please route this patch via armsoc?

Thanks adding Tero to loop so he can queue it.

Regards,

Tony

2019-06-04 08:36:52

by Yue Haibing

Subject: Re: [PATCH] arm64: arch_k3: Fix kconfig dependency warning

Hi all,

Friendly ping:

Who can take this?

On 2019/5/10 11:52, YueHaibing wrote:
> Fix Kbuild warning when SOC_TI is not set
>
> WARNING: unmet direct dependencies detected for TI_SCI_INTA_IRQCHIP
> Depends on [n]: TI_SCI_PROTOCOL [=y] && SOC_TI [=n]
> Selected by [y]:
> - ARCH_K3 [=y]
>
> Fixes: 009669e74813 ("arm64: arch_k3: Enable interrupt controller drivers")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> arch/arm64/Kconfig.platforms | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 42eca65..9d1292f 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -88,6 +88,7 @@ config ARCH_K3
> bool "Texas Instruments Inc. K3 multicore SoC architecture"
> select PM_GENERIC_DOMAINS if PM
> select MAILBOX
> + select SOC_TI
> select TI_MESSAGE_MANAGER
> select TI_SCI_PROTOCOL
> select TI_SCI_INTR_IRQCHIP
>

2019-06-04 13:24:52

by Tero Kristo

Subject: Re: [PATCH] arm64: arch_k3: Fix kconfig dependency warning

Sorry, this has sort of slipped through. I can pick this up and queue
towards 5.2-rc fixes.

-Tero

On 04/06/2019 11:33, Yuehaibing wrote:
> Hi all,
>
> Friendly ping:
>
> Who can take this?
>
> On 2019/5/10 11:52, YueHaibing wrote:
>> Fix Kbuild warning when SOC_TI is not set
>>
>> WARNING: unmet direct dependencies detected for TI_SCI_INTA_IRQCHIP
>> Depends on [n]: TI_SCI_PROTOCOL [=y] && SOC_TI [=n]
>> Selected by [y]:
>> - ARCH_K3 [=y]
>>
>> Fixes: 009669e74813 ("arm64: arch_k3: Enable interrupt controller drivers")
>> Signed-off-by: YueHaibing <[email protected]>
>> ---
>> arch/arm64/Kconfig.platforms | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index 42eca65..9d1292f 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -88,6 +88,7 @@ config ARCH_K3
>> bool "Texas Instruments Inc. K3 multicore SoC architecture"
>> select PM_GENERIC_DOMAINS if PM
>> select MAILBOX
>> + select SOC_TI
>> select TI_MESSAGE_MANAGER
>> select TI_SCI_PROTOCOL
>> select TI_SCI_INTR_IRQCHIP
>>
>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki