2019-02-13 13:44:21

by Julien Thierry

Subject: [PATCH] genirq: Fix wrong name in request_percpu_nmi() description

ready_percpu_nmi() was the previous name of prepare_percpu_nmi(). Update
request_percpu_nmi() comment with the correct function name.

Signed-off-by: Julien Thierry <[email protected]>
Reported-by: Li Wei <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Marc Zyngier <[email protected]>
---
kernel/irq/manage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Note: This issue is in next, not yet in mainline. Should apply cleanly
on top of next.

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index aea87ec..9ec34a2 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2431,8 +2431,8 @@ int __request_percpu_irq(unsigned int irq, irq_handler_t handler,
* @dev_id: A percpu cookie passed back to the handler function
*
* This call allocates interrupt resources for a per CPU NMI. Per CPU NMIs
- * have to be setup on each CPU by calling ready_percpu_nmi() before being
- * enabled on the same CPU by using enable_percpu_nmi().
+ * have to be setup on each CPU by calling prepare_percpu_nmi() before
+ * being enabled on the same CPU by using enable_percpu_nmi().
*
* Dev_id must be globally unique. It is a per-cpu variable, and
* the handler gets called with the interrupted CPU's instance of
--
1.9.1

2019-02-14 17:58:27

by Marc Zyngier

Subject: Re: [PATCH] genirq: Fix wrong name in request_percpu_nmi() description

On Wed, 13 Feb 2019 10:09:19 +0000,
Julien Thierry <[email protected]> wrote:
>
> ready_percpu_nmi() was the previous name of prepare_percpu_nmi(). Update
> request_percpu_nmi() comment with the correct function name.
>
> Signed-off-by: Julien Thierry <[email protected]>
> Reported-by: Li Wei <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Marc Zyngier <[email protected]>
> ---
> kernel/irq/manage.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Note: This issue is in next, not yet in mainline. Should apply cleanly
> on top of next.

Applied on top of irq/irqchip-next, which already contains the
generic-nmi branch.

Thanks,

M.

--
Jazz is not dead, it just smell funny.