2023-06-13 20:29:56

by Rob Herring

[permalink] [raw]
Subject: [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep"

"regstep" may be deprecated, but it still needs a type.

Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
index 85d9efb743ee..d9ef86729011 100644
--- a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
+++ b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
@@ -60,6 +60,7 @@ properties:
default: 0

regstep:
+ $ref: /schemas/types.yaml#/definitions/uint32
description: |
deprecated, use reg-shift above
deprecated: true
--
2.39.2



2023-06-13 21:11:03

by Peter Korsgaard

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep"

>>>>> "Rob" == Rob Herring <[email protected]> writes:

> "regstep" may be deprecated, but it still needs a type.
> Signed-off-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml | 1 +
> 1 file changed, 1 insertion(+)

> diff --git a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> index 85d9efb743ee..d9ef86729011 100644
> --- a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> +++ b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> @@ -60,6 +60,7 @@ properties:
> default: 0

> regstep:
> + $ref: /schemas/types.yaml#/definitions/uint32

Reviewed-by: Peter Korsgaard <[email protected]>

--
Bye, Peter Korsgaard

2023-06-13 21:35:03

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep"

On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.

Mea culpa!
Reviewed-by: Conor Dooley <[email protected]>

>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> index 85d9efb743ee..d9ef86729011 100644
> --- a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> +++ b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> @@ -60,6 +60,7 @@ properties:
> default: 0
>
> regstep:
> + $ref: /schemas/types.yaml#/definitions/uint32
> description: |
> deprecated, use reg-shift above
> deprecated: true
> --
> 2.39.2
>

Attachments:
(No filename) (937.00 B)
 signature.asc (235.00 B)
 Download all attachments

2023-06-14 01:08:15

by Andi Shyti

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep"

Hi Rob,

On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.
>
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Andi Shyti <[email protected]>

Thanks,
Andi

2023-06-14 09:04:13

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: i2c: opencores: Add missing type for "regstep"

On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.
>
> Signed-off-by: Rob Herring <[email protected]>

Added fixes tag and applied to for-current, thanks!

Attachments:
(No filename) (230.00 B)
 signature.asc (849.00 B)
 Download all attachments