2019-06-04 10:18:29

by Masahiro Yamada

Subject: [PATCH 14/15] fixup: kbuild: add support for ensuring headers are self-contained

This is needed to avoid regeneration of header-test C files.

This will go away when Jani send v2.

Signed-off-by: Masahiro Yamada <[email protected]>
---

scripts/Makefile.build | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 2b4d56483c2e..067e98628664 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -298,10 +298,9 @@ $(obj)/%.lst: $(src)/%.c FORCE
# ---------------------------------------------------------------------------

quiet_cmd_header_test = HDRTEST $@
- cmd_header_test = echo "\#include \"$(<F)\"" > $@
+ cmd_header_test = echo "\#include \"$*.h\"" > $@

-# FIXME: would be nice to be able to limit this implicit rule to header-test-y
-$(obj)/%.header_test.c: $(src)/%.h FORCE
+$(obj)/%.header_test.c:
$(call if_changed,header_test)

# Compile assembler sources (.S)
--
2.17.1

2019-06-04 12:52:29

by Jani Nikula

Subject: Re: [PATCH 14/15] fixup: kbuild: add support for ensuring headers are self-contained

On Tue, 04 Jun 2019, Masahiro Yamada <[email protected]> wrote:
> This is needed to avoid regeneration of header-test C files.
>
> This will go away when Jani send v2.

Done, in reply to patch 13.

Thanks,
Jani.


>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> scripts/Makefile.build | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 2b4d56483c2e..067e98628664 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -298,10 +298,9 @@ $(obj)/%.lst: $(src)/%.c FORCE
> # ---------------------------------------------------------------------------
>
> quiet_cmd_header_test = HDRTEST $@
> - cmd_header_test = echo "\#include \"$(<F)\"" > $@
> + cmd_header_test = echo "\#include \"$*.h\"" > $@
>
> -# FIXME: would be nice to be able to limit this implicit rule to header-test-y
> -$(obj)/%.header_test.c: $(src)/%.h FORCE
> +$(obj)/%.header_test.c:
> $(call if_changed,header_test)
>
> # Compile assembler sources (.S)

--
Jani Nikula, Intel Open Source Graphics Center