2018-09-24 14:59:05

by Anshuman Khandual

[permalink] [raw]
Subject: [PATCH] mm/hugetlb: Add mmap() encodings for 32MB and 512MB page sizes

ARM64 architecture also supports 32MB and 512MB HugeTLB page sizes.
This just adds mmap() system call argument encoding for them.

Signed-off-by: Anshuman Khandual <[email protected]>
---
include/uapi/asm-generic/hugetlb_encode.h | 2 ++
include/uapi/linux/mman.h | 2 ++
2 files changed, 4 insertions(+)

diff --git a/include/uapi/asm-generic/hugetlb_encode.h b/include/uapi/asm-generic/hugetlb_encode.h
index e4732d3..b0f8e87 100644
--- a/include/uapi/asm-generic/hugetlb_encode.h
+++ b/include/uapi/asm-generic/hugetlb_encode.h
@@ -26,7 +26,9 @@
#define HUGETLB_FLAG_ENCODE_2MB (21 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_8MB (23 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_16MB (24 << HUGETLB_FLAG_ENCODE_SHIFT)
+#define HUGETLB_FLAG_ENCODE_32MB (25 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_256MB (28 << HUGETLB_FLAG_ENCODE_SHIFT)
+#define HUGETLB_FLAG_ENCODE_512MB (29 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_1GB (30 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_2GB (31 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_16GB (34 << HUGETLB_FLAG_ENCODE_SHIFT)
diff --git a/include/uapi/linux/mman.h b/include/uapi/linux/mman.h
index bfd5938..d0f515d 100644
--- a/include/uapi/linux/mman.h
+++ b/include/uapi/linux/mman.h
@@ -28,7 +28,9 @@
#define MAP_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
#define MAP_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
#define MAP_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
+#define MAP_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
#define MAP_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
+#define MAP_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
#define MAP_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
#define MAP_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
#define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
--
2.7.4



2018-09-24 16:49:35

by Mike Kravetz

[permalink] [raw]
Subject: Re: [PATCH] mm/hugetlb: Add mmap() encodings for 32MB and 512MB page sizes

On 9/24/18 7:06 AM, Anshuman Khandual wrote:
> ARM64 architecture also supports 32MB and 512MB HugeTLB page sizes.
> This just adds mmap() system call argument encoding for them.
>
> Signed-off-by: Anshuman Khandual <[email protected]>
> ---
> include/uapi/asm-generic/hugetlb_encode.h | 2 ++
> include/uapi/linux/mman.h | 2 ++
> 2 files changed, 4 insertions(+)

Thanks Anshuman,

However, I think we should also add similar definitions in:
uapi/linux/memfd.h
uapi/linux/shm.h

--
Mike Kravetz

2018-09-25 02:09:33

by Anshuman Khandual

[permalink] [raw]
Subject: [PATCH V2] mm/hugetlb: Add mmap() encodings for 32MB and 512MB page sizes

ARM64 architecture also supports 32MB and 512MB HugeTLB page sizes.
This just adds mmap() system call argument encoding for them.

Signed-off-by: Anshuman Khandual <[email protected]>
---

Changes in V2:
- Updated SHM and MFD definitions per Mike

include/uapi/asm-generic/hugetlb_encode.h | 2 ++
include/uapi/linux/memfd.h | 2 ++
include/uapi/linux/mman.h | 2 ++
include/uapi/linux/shm.h | 2 ++
4 files changed, 8 insertions(+)

diff --git a/include/uapi/asm-generic/hugetlb_encode.h b/include/uapi/asm-generic/hugetlb_encode.h
index e4732d3..b0f8e87 100644
--- a/include/uapi/asm-generic/hugetlb_encode.h
+++ b/include/uapi/asm-generic/hugetlb_encode.h
@@ -26,7 +26,9 @@
#define HUGETLB_FLAG_ENCODE_2MB (21 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_8MB (23 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_16MB (24 << HUGETLB_FLAG_ENCODE_SHIFT)
+#define HUGETLB_FLAG_ENCODE_32MB (25 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_256MB (28 << HUGETLB_FLAG_ENCODE_SHIFT)
+#define HUGETLB_FLAG_ENCODE_512MB (29 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_1GB (30 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_2GB (31 << HUGETLB_FLAG_ENCODE_SHIFT)
#define HUGETLB_FLAG_ENCODE_16GB (34 << HUGETLB_FLAG_ENCODE_SHIFT)
diff --git a/include/uapi/linux/memfd.h b/include/uapi/linux/memfd.h
index 015a4c0..7a8a267 100644
--- a/include/uapi/linux/memfd.h
+++ b/include/uapi/linux/memfd.h
@@ -25,7 +25,9 @@
#define MFD_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
#define MFD_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
#define MFD_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
+#define MFD_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
#define MFD_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
+#define MFD_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
#define MFD_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
#define MFD_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
#define MFD_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
diff --git a/include/uapi/linux/mman.h b/include/uapi/linux/mman.h
index bfd5938..d0f515d 100644
--- a/include/uapi/linux/mman.h
+++ b/include/uapi/linux/mman.h
@@ -28,7 +28,9 @@
#define MAP_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
#define MAP_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
#define MAP_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
+#define MAP_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
#define MAP_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
+#define MAP_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
#define MAP_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
#define MAP_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
#define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
diff --git a/include/uapi/linux/shm.h b/include/uapi/linux/shm.h
index dde1344..6507ad0 100644
--- a/include/uapi/linux/shm.h
+++ b/include/uapi/linux/shm.h
@@ -65,7 +65,9 @@ struct shmid_ds {
#define SHM_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
#define SHM_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
#define SHM_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
+#define SHM_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
#define SHM_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
+#define SHM_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
#define SHM_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
#define SHM_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
#define SHM_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
--
2.7.4


2018-09-25 10:04:30

by Punit Agrawal

[permalink] [raw]
Subject: Re: [PATCH V2] mm/hugetlb: Add mmap() encodings for 32MB and 512MB page sizes

Anshuman Khandual <[email protected]> writes:

> ARM64 architecture also supports 32MB and 512MB HugeTLB page sizes.
> This just adds mmap() system call argument encoding for them.
>
> Signed-off-by: Anshuman Khandual <[email protected]>

Thanks for adding the encodings.

Acked-by: Punit Agrawal <[email protected]>

> ---
>
> Changes in V2:
> - Updated SHM and MFD definitions per Mike
>
> include/uapi/asm-generic/hugetlb_encode.h | 2 ++
> include/uapi/linux/memfd.h | 2 ++
> include/uapi/linux/mman.h | 2 ++
> include/uapi/linux/shm.h | 2 ++
> 4 files changed, 8 insertions(+)
>
> diff --git a/include/uapi/asm-generic/hugetlb_encode.h b/include/uapi/asm-generic/hugetlb_encode.h
> index e4732d3..b0f8e87 100644
> --- a/include/uapi/asm-generic/hugetlb_encode.h
> +++ b/include/uapi/asm-generic/hugetlb_encode.h
> @@ -26,7 +26,9 @@
> #define HUGETLB_FLAG_ENCODE_2MB (21 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_8MB (23 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_16MB (24 << HUGETLB_FLAG_ENCODE_SHIFT)
> +#define HUGETLB_FLAG_ENCODE_32MB (25 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_256MB (28 << HUGETLB_FLAG_ENCODE_SHIFT)
> +#define HUGETLB_FLAG_ENCODE_512MB (29 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_1GB (30 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_2GB (31 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_16GB (34 << HUGETLB_FLAG_ENCODE_SHIFT)
> diff --git a/include/uapi/linux/memfd.h b/include/uapi/linux/memfd.h
> index 015a4c0..7a8a267 100644
> --- a/include/uapi/linux/memfd.h
> +++ b/include/uapi/linux/memfd.h
> @@ -25,7 +25,9 @@
> #define MFD_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
> #define MFD_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
> #define MFD_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
> +#define MFD_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
> #define MFD_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
> +#define MFD_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
> #define MFD_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
> #define MFD_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
> #define MFD_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
> diff --git a/include/uapi/linux/mman.h b/include/uapi/linux/mman.h
> index bfd5938..d0f515d 100644
> --- a/include/uapi/linux/mman.h
> +++ b/include/uapi/linux/mman.h
> @@ -28,7 +28,9 @@
> #define MAP_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
> #define MAP_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
> #define MAP_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
> +#define MAP_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
> #define MAP_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
> +#define MAP_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
> #define MAP_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
> #define MAP_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
> #define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
> diff --git a/include/uapi/linux/shm.h b/include/uapi/linux/shm.h
> index dde1344..6507ad0 100644
> --- a/include/uapi/linux/shm.h
> +++ b/include/uapi/linux/shm.h
> @@ -65,7 +65,9 @@ struct shmid_ds {
> #define SHM_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
> #define SHM_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
> #define SHM_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
> +#define SHM_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
> #define SHM_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
> +#define SHM_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
> #define SHM_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
> #define SHM_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
> #define SHM_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB

2018-09-25 16:41:32

by Mike Kravetz

[permalink] [raw]
Subject: Re: [PATCH V2] mm/hugetlb: Add mmap() encodings for 32MB and 512MB page sizes

On 9/24/18 7:08 PM, Anshuman Khandual wrote:
> ARM64 architecture also supports 32MB and 512MB HugeTLB page sizes.
> This just adds mmap() system call argument encoding for them.
>
> Signed-off-by: Anshuman Khandual <[email protected]>
> ---
>
> Changes in V2:
> - Updated SHM and MFD definitions per Mike

Thanks Anshuman,

Acked-by: Mike Kravetz <[email protected]>

--
Mike Kravetz

>
> include/uapi/asm-generic/hugetlb_encode.h | 2 ++
> include/uapi/linux/memfd.h | 2 ++
> include/uapi/linux/mman.h | 2 ++
> include/uapi/linux/shm.h | 2 ++
> 4 files changed, 8 insertions(+)
>
> diff --git a/include/uapi/asm-generic/hugetlb_encode.h b/include/uapi/asm-generic/hugetlb_encode.h
> index e4732d3..b0f8e87 100644
> --- a/include/uapi/asm-generic/hugetlb_encode.h
> +++ b/include/uapi/asm-generic/hugetlb_encode.h
> @@ -26,7 +26,9 @@
> #define HUGETLB_FLAG_ENCODE_2MB (21 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_8MB (23 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_16MB (24 << HUGETLB_FLAG_ENCODE_SHIFT)
> +#define HUGETLB_FLAG_ENCODE_32MB (25 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_256MB (28 << HUGETLB_FLAG_ENCODE_SHIFT)
> +#define HUGETLB_FLAG_ENCODE_512MB (29 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_1GB (30 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_2GB (31 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_16GB (34 << HUGETLB_FLAG_ENCODE_SHIFT)
> diff --git a/include/uapi/linux/memfd.h b/include/uapi/linux/memfd.h
> index 015a4c0..7a8a267 100644
> --- a/include/uapi/linux/memfd.h
> +++ b/include/uapi/linux/memfd.h
> @@ -25,7 +25,9 @@
> #define MFD_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
> #define MFD_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
> #define MFD_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
> +#define MFD_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
> #define MFD_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
> +#define MFD_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
> #define MFD_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
> #define MFD_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
> #define MFD_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
> diff --git a/include/uapi/linux/mman.h b/include/uapi/linux/mman.h
> index bfd5938..d0f515d 100644
> --- a/include/uapi/linux/mman.h
> +++ b/include/uapi/linux/mman.h
> @@ -28,7 +28,9 @@
> #define MAP_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
> #define MAP_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
> #define MAP_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
> +#define MAP_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
> #define MAP_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
> +#define MAP_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
> #define MAP_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
> #define MAP_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
> #define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
> diff --git a/include/uapi/linux/shm.h b/include/uapi/linux/shm.h
> index dde1344..6507ad0 100644
> --- a/include/uapi/linux/shm.h
> +++ b/include/uapi/linux/shm.h
> @@ -65,7 +65,9 @@ struct shmid_ds {
> #define SHM_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
> #define SHM_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
> #define SHM_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
> +#define SHM_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
> #define SHM_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
> +#define SHM_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
> #define SHM_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
> #define SHM_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
> #define SHM_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
>