2024-04-10 22:48:01

by Thomas Gleixner

Subject: [patch V2 08/50] posix-cpu-timers: Save interval only for armed timers

There is no point to return the interval for timers which have been
disarmed.

Signed-off-by: Thomas Gleixner <[email protected]>
---
V2: Split out into new patch to make review simpler - Frederic
---
kernel/time/posix-cpu-timers.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)

--- a/kernel/time/posix-cpu-timers.c
+++ b/kernel/time/posix-cpu-timers.c
@@ -809,17 +809,15 @@ static void posix_cpu_timer_get(struct k

rcu_read_lock();
p = cpu_timer_task_rcu(timer);
- if (p) {
+ if (p && cpu_timer_getexpires(&timer->it.cpu)) {
itp->it_interval = ktime_to_timespec64(timer->it_interval);

- if (cpu_timer_getexpires(&timer->it.cpu)) {
- if (CPUCLOCK_PERTHREAD(timer->it_clock))
- now = cpu_clock_sample(clkid, p);
- else
- now = cpu_clock_sample_group(clkid, p, false);
+ if (CPUCLOCK_PERTHREAD(timer->it_clock))
+ now = cpu_clock_sample(clkid, p);
+ else
+ now = cpu_clock_sample_group(clkid, p, false);

- __posix_cpu_timer_get(timer, itp, now);
- }
+ __posix_cpu_timer_get(timer, itp, now);
}
rcu_read_unlock();
}

2024-04-11 14:25:22

by Anna-Maria Behnsen

Subject: Re: [patch V2 08/50] posix-cpu-timers: Save interval only for armed timers

Thomas Gleixner <[email protected]> writes:

> There is no point to return the interval for timers which have been
> disarmed.
>

common_timer_get() returns/updates interval unconditionally - so
behavior then differs.

Thanks,

Anna-Maria

2024-04-11 22:01:12

by Thomas Gleixner

Subject: Re: [patch V2 08/50] posix-cpu-timers: Save interval only for armed timers

On Thu, Apr 11 2024 at 16:25, Anna-Maria Behnsen wrote:

> Thomas Gleixner <[email protected]> writes:
>
>> There is no point to return the interval for timers which have been
>> disarmed.
>>
> common_timer_get() returns/updates interval unconditionally - so
> behavior then differs.

Good catch! We really want to make this consistent.