2020-05-06 17:37:30

by Vinicius Costa Gomes

[permalink] [raw]
Subject: Re: [net-next PATCH] net: hsr: fix incorrect type usage for protocol variable

Hi Murali,

Murali Karicheri <[email protected]> writes:

> Fix following sparse checker warning:-
>
> net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different base types)
> net/hsr/hsr_slave.c:38:18: expected unsigned short [unsigned] [usertype] protocol
> net/hsr/hsr_slave.c:38:18: got restricted __be16 [usertype] h_proto
> net/hsr/hsr_slave.c:39:25: warning: restricted __be16 degrades to integer
> net/hsr/hsr_slave.c:39:57: warning: restricted __be16 degrades to integer
>
> Signed-off-by: Murali Karicheri <[email protected]>
> ---

I think this patch should go via the net tree, as it is a warning fix.
Anyway...

Acked-by: Vinicius Costa Gomes <[email protected]>


--
Vinicius


2020-05-07 01:36:16

by Karicheri, Muralidharan

[permalink] [raw]
Subject: Re: [net-next PATCH] net: hsr: fix incorrect type usage for protocol variable

Hi Vinicius,

On 5/6/20 1:33 PM, Vinicius Costa Gomes wrote:
> Hi Murali,
>
> Murali Karicheri <[email protected]> writes:
>
>> Fix following sparse checker warning:-
>>
>> net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different base types)
>> net/hsr/hsr_slave.c:38:18: expected unsigned short [unsigned] [usertype] protocol
>> net/hsr/hsr_slave.c:38:18: got restricted __be16 [usertype] h_proto
>> net/hsr/hsr_slave.c:39:25: warning: restricted __be16 degrades to integer
>> net/hsr/hsr_slave.c:39:57: warning: restricted __be16 degrades to integer
>>
>> Signed-off-by: Murali Karicheri <[email protected]>
>> ---
>
> I think this patch should go via the net tree, as it is a warning fix.
> Anyway...
>
> Acked-by: Vinicius Costa Gomes <[email protected]>
>
>
Thanks. I will re-send it with net prefix and you ack. I thought since
this is just a warning, it is not that serious to include in net tree.

--
Murali Karicheri
Texas Instruments