2023-05-29 14:50:26

by Franziska Näpelt

Subject: [PATCH] ARM: ep93xx: Fix whitespace issues

This removes the following checkpatch issues:
- ERROR: code indent should use tabs where possible
- WARNING: please, no spaces at the start of a line

Signed-off-by: Franziska Naepelt <[email protected]>
---
arch/arm/mach-ep93xx/timer-ep93xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/timer-ep93xx.c
index dd4b164d1831..5bfabbdde463 100644
--- a/arch/arm/mach-ep93xx/timer-ep93xx.c
+++ b/arch/arm/mach-ep93xx/timer-ep93xx.c
@@ -82,8 +82,8 @@ static int ep93xx_clkevt_set_next_event(unsigned long next,
/* Set next event */
writel(next, EP93XX_TIMER3_LOAD);
writel(tmode | EP93XX_TIMER123_CONTROL_ENABLE,
- EP93XX_TIMER3_CONTROL);
- return 0;
+ EP93XX_TIMER3_CONTROL);
+ return 0;
}



base-commit: 7877cb91f1081754a1487c144d85dc0d2e2e7fc4
--
2.39.2 (Apple Git-143)

2023-05-29 15:26:41

by Alexander Sverdlin

Subject: Re: [PATCH] ARM: ep93xx: Fix whitespace issues

Hello Franziska,

On Mon, 2023-05-29 at 16:33 +0200, Franziska Naepelt wrote:
> This removes the following checkpatch issues:
> - ERROR: code indent should use tabs where possible
> - WARNING: please, no spaces at the start of a line
>
> Signed-off-by: Franziska Naepelt <[email protected]>

thanks for the patch!
However the file is going away at some point anyway:
https://lore.kernel.org/lkml/[email protected]/

> ---
>  arch/arm/mach-ep93xx/timer-ep93xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/timer-ep93xx.c
> index dd4b164d1831..5bfabbdde463 100644
> --- a/arch/arm/mach-ep93xx/timer-ep93xx.c
> +++ b/arch/arm/mach-ep93xx/timer-ep93xx.c
> @@ -82,8 +82,8 @@ static int ep93xx_clkevt_set_next_event(unsigned long next,
>         /* Set next event */
>         writel(next, EP93XX_TIMER3_LOAD);
>         writel(tmode | EP93XX_TIMER123_CONTROL_ENABLE,
> -              EP93XX_TIMER3_CONTROL);
> -        return 0;
> +                  EP93XX_TIMER3_CONTROL);
> +       return 0;
>  }
>  

--
Alexander Sverdlin.

2023-05-30 05:14:20

by Franziska Näpelt

Subject: Re: [PATCH] ARM: ep93xx: Fix whitespace issues

Hi Alexander,

Am Mo., 29. Mai 2023 um 17:19 Uhr schrieb Alexander Sverdlin
<[email protected]>:
>
> Hello Franziska,
>
> On Mon, 2023-05-29 at 16:33 +0200, Franziska Naepelt wrote:
> > This removes the following checkpatch issues:
> > - ERROR: code indent should use tabs where possible
> > - WARNING: please, no spaces at the start of a line
> >
> > Signed-off-by: Franziska Naepelt <[email protected]>
>
> thanks for the patch!
> However the file is going away at some point anyway:
> https://lore.kernel.org/lkml/[email protected]/

Thanks for the heads up - I'm sorry I missed that.

>
> > ---
> > arch/arm/mach-ep93xx/timer-ep93xx.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/timer-ep93xx.c
> > index dd4b164d1831..5bfabbdde463 100644
> > --- a/arch/arm/mach-ep93xx/timer-ep93xx.c
> > +++ b/arch/arm/mach-ep93xx/timer-ep93xx.c
> > @@ -82,8 +82,8 @@ static int ep93xx_clkevt_set_next_event(unsigned long next,
> > /* Set next event */
> > writel(next, EP93XX_TIMER3_LOAD);
> > writel(tmode | EP93XX_TIMER123_CONTROL_ENABLE,
> > - EP93XX_TIMER3_CONTROL);
> > - return 0;
> > + EP93XX_TIMER3_CONTROL);
> > + return 0;
> > }
> >
>
> --
> Alexander Sverdlin.
>

Franziska