2019-07-11 07:01:58

by Yue Haibing

Subject: [PATCH] watchdog: digicolor_wdt: remove unused variable 'ret'

commit cdad26977e3f ("watchdog: digicolor_wdt: drop
warning after registering device") left this unused
variable, it can be removed.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/watchdog/digicolor_wdt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
index 33cda95..073d378 100644
--- a/drivers/watchdog/digicolor_wdt.c
+++ b/drivers/watchdog/digicolor_wdt.c
@@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct dc_wdt *wdt;
- int ret;

wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
if (!wdt)
--
2.7.4

2019-07-11 07:47:59

by Baruch Siach

Subject: Re: [PATCH] watchdog: digicolor_wdt: remove unused variable 'ret'

Hi YueHaibing,

On Thu, Jul 11 2019, YueHaibing wrote:
> commit cdad26977e3f ("watchdog: digicolor_wdt: drop
> warning after registering device") left this unused
> variable, it can be removed.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Third time's a charm:

https://patchwork.kernel.org/patch/11037487/
https://patchwork.kernel.org/patch/11038317/

baruch

> drivers/watchdog/digicolor_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/digicolor_wdt.c b/drivers/watchdog/digicolor_wdt.c
> index 33cda95..073d378 100644
> --- a/drivers/watchdog/digicolor_wdt.c
> +++ b/drivers/watchdog/digicolor_wdt.c
> @@ -118,7 +118,6 @@ static int dc_wdt_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct dc_wdt *wdt;
> - int ret;
>
> wdt = devm_kzalloc(dev, sizeof(struct dc_wdt), GFP_KERNEL);
> if (!wdt)

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -