NT_PRFPREG note is named "CORE". Correct the comment accordingly.
Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support")
Signed-off-by: Baruch Siach <[email protected]>
---
v2: Swap "CORE" and "LINUX" as noted by Kees
---
include/uapi/linux/elf.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git include/uapi/linux/elf.h include/uapi/linux/elf.h
index ac3da855fb19..4d1c8d46e7f0 100644
--- include/uapi/linux/elf.h
+++ include/uapi/linux/elf.h
@@ -372,7 +372,8 @@ typedef struct elf64_shdr {
* Notes used in ET_CORE. Architectures export some of the arch register sets
* using the corresponding note types via the PTRACE_GETREGSET and
* PTRACE_SETREGSET requests.
- * The note name for all these is "LINUX".
+ * The note name for these types is "LINUX", except NT_PRFPREG that is named
+ * "CORE".
*/
#define NT_PRSTATUS 1
#define NT_PRFPREG 2
--
2.40.1
On Fri, Jun 23, 2023 at 08:50:11AM +0300, Baruch Siach wrote:
> NT_PRFPREG note is named "CORE". Correct the comment accordingly.
>
> Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support")
> Signed-off-by: Baruch Siach <[email protected]>
> ---
>
> v2: Swap "CORE" and "LINUX" as noted by Kees
> ---
> include/uapi/linux/elf.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git include/uapi/linux/elf.h include/uapi/linux/elf.h
> index ac3da855fb19..4d1c8d46e7f0 100644
> --- include/uapi/linux/elf.h
> +++ include/uapi/linux/elf.h
Hi, I took this patch, but it seems something is misconfigured on your
end for patch generation -- normally I'd expect to need "-p1", not "-p0"
to apply patches. Are you using "git format-patch" to produce these
patches?
--
Kees Cook
Hi Kees,
On Fri, Jun 23 2023, Kees Cook wrote:
> On Fri, Jun 23, 2023 at 08:50:11AM +0300, Baruch Siach wrote:
>> NT_PRFPREG note is named "CORE". Correct the comment accordingly.
>>
>> Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support")
>> Signed-off-by: Baruch Siach <[email protected]>
>> ---
>>
>> v2: Swap "CORE" and "LINUX" as noted by Kees
>> ---
>> include/uapi/linux/elf.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git include/uapi/linux/elf.h include/uapi/linux/elf.h
>> index ac3da855fb19..4d1c8d46e7f0 100644
>> --- include/uapi/linux/elf.h
>> +++ include/uapi/linux/elf.h
>
> Hi, I took this patch, but it seems something is misconfigured on your
> end for patch generation -- normally I'd expect to need "-p1", not "-p0"
> to apply patches. Are you using "git format-patch" to produce these
> patches?
I recently enabled diff.noprefix for easier copying of file names from
git-diff output. I have now noticed the git-format-patch is also
affected, and that it breaks the default git-am -p1. So I have reverted
diff.noprefix to its default.
Sorry for the inconvenience, and thanks for letting me know.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -