2022-03-08 18:50:21

by CGEL

Subject: [PATCH] input: fix variable type

From: Lv Ruyi (CGEL ZTE) <[email protected]>

The irq is defined unsigned int. If the platform_get_irq return a negative
value, data type cast may result in error.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Lv Ruyi (CGEL ZTE) <[email protected]>
---
drivers/input/keyboard/mt6779-keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
index 5ff23250ed37..0dbbddc7f298 100644
--- a/drivers/input/keyboard/mt6779-keypad.c
+++ b/drivers/input/keyboard/mt6779-keypad.c
@@ -91,7 +91,7 @@ static void mt6779_keypad_clk_disable(void *data)
static int mt6779_keypad_pdrv_probe(struct platform_device *pdev)
{
struct mt6779_keypad *keypad;
- unsigned int irq;
+ int irq;
u32 debounce;
bool wakeup;
int error;
--
2.25.1

2022-03-09 07:56:30

by Mattijs Korpershoek

Subject: Re: [PATCH] input: fix variable type

On Tue, Mar 08, 2022 at 02:50, [email protected] wrote:

> From: Lv Ruyi (CGEL ZTE) <[email protected]>
>
> The irq is defined unsigned int. If the platform_get_irq return a negative
> value, data type cast may result in error.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Lv Ruyi (CGEL ZTE) <[email protected]>
> ---
> drivers/input/keyboard/mt6779-keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
> index 5ff23250ed37..0dbbddc7f298 100644
> --- a/drivers/input/keyboard/mt6779-keypad.c
> +++ b/drivers/input/keyboard/mt6779-keypad.c
> @@ -91,7 +91,7 @@ static void mt6779_keypad_clk_disable(void *data)
> static int mt6779_keypad_pdrv_probe(struct platform_device *pdev)
> {
> struct mt6779_keypad *keypad;
> - unsigned int irq;
> + int irq;
> u32 debounce;
> bool wakeup;
> int error;

Reviewed-by: Mattijs Korpershoek <[email protected]>
> --
> 2.25.1