2020-02-18 08:26:30

by Esben Haabendal

[permalink] [raw]
Subject: [PATCH 0/8] net: ll_temac: Bugfixes and ethtool support

Patch 1-4 brings fixes a number of bugs observed.
Patch 5-6 are simple cleanup, removing two unused struct fields.
Patch 7-8 add ethtool support for controlling rx and tx ring sizes and irq
coalesce parameters.

Esben Haabendal (9):
net: ll_temac: Fix race condition causing TX hang
net: ll_temac: Add more error handling of dma_map_single() calls
net: ll_temac: Fix RX buffer descriptor handling on GFP_ATOMIC
pressure
net: ll_temac: Handle DMA halt condition caused by buffer underrun
net: ll_temac: Remove unused tx_bd_next struct field
net: ll_temac: Remove unused start_p variable
net: ll_temac: Make RX/TX ring sizes configurable
net: ll_temac: Add ethtool support for coalesce parameters

drivers/net/ethernet/xilinx/ll_temac.h | 12 +-
drivers/net/ethernet/xilinx/ll_temac_main.c | 435 ++++++++++++++++----
2 files changed, 367 insertions(+), 80 deletions(-)

--
2.25.0


2020-02-18 19:50:37

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 0/8] net: ll_temac: Bugfixes and ethtool support


Several errors in this submission:

1) Do not mix bug fixes and new features. Submit the bug fixes
targetting 'net', and then wait for net to be merged into
net-next at which time you can submit the new features on
top.

2) As per Documentation/networking/netdev-FAQ.rst you should not
ever CC: stable for networking patches, we submit bug fixes to
stable ourselves.

Thank you.

2020-02-19 10:53:24

by Esben Haabendal

[permalink] [raw]
Subject: Re: [PATCH 0/8] net: ll_temac: Bugfixes and ethtool support

David Miller <[email protected]> writes:

> Several errors in this submission:
>
> 1) Do not mix bug fixes and new features. Submit the bug fixes
> targetting 'net', and then wait for net to be merged into
> net-next at which time you can submit the new features on
> top.
>
> 2) As per Documentation/networking/netdev-FAQ.rst you should not
> ever CC: stable for networking patches, we submit bug fixes to
> stable ourselves.

Got it. I will resend against net and net-next.

/Esben