2019-03-04 21:49:32

by Helen Koike

[permalink] [raw]
Subject: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd gpio pull

Raspberry pi board model B revison 2 have the hot plug detector gpio
active high (and not low as it was in the dts).

Signed-off-by: Helen Koike <[email protected]>
Reviewed-by: Eric Anholt <[email protected]>
---
arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
index 5641d162dfdb..28e7513ce617 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
@@ -93,7 +93,7 @@
};

&hdmi {
- hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
+ hpd-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>;
};

&pwm {
--
2.20.1



2019-03-04 22:10:55

by Stefan Wahren

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd gpio pull

Hi,

since this patch change only one board, the subject could be more specific:

ARM: dts: bcm2835-rpi-b-rev2: Fix hdmi hpd gpio pull

> Helen Koike <[email protected]> hat am 4. März 2019 um 22:48 geschrieben:
>
>
> Raspberry pi board model B revison 2 have the hot plug detector gpio
> active high (and not low as it was in the dts).
>
> Signed-off-by: Helen Koike <[email protected]>
> Reviewed-by: Eric Anholt <[email protected]>

I think we should add a Fixes tag here, so it could be backported.

@Eric: Feel free to take V2

Thanks

2019-03-04 23:28:30

by Eric Anholt

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd gpio pull

Stefan Wahren <[email protected]> writes:

> Hi,
>
> since this patch change only one board, the subject could be more specific:
>
> ARM: dts: bcm2835-rpi-b-rev2: Fix hdmi hpd gpio pull
>
>> Helen Koike <[email protected]> hat am 4. März 2019 um 22:48 geschrieben:
>>
>>
>> Raspberry pi board model B revison 2 have the hot plug detector gpio
>> active high (and not low as it was in the dts).
>>
>> Signed-off-by: Helen Koike <[email protected]>
>> Reviewed-by: Eric Anholt <[email protected]>
>
> I think we should add a Fixes tag here, so it could be backported.
>
> @Eric: Feel free to take V2

Added a fixes tag, and I'll submit PRs for this and the PM fixes now.


Attachments:
signature.asc (847.00 B)