2014-12-22 17:25:55

by Marcel Holtmann

Subject: [PATCH] module: Remove double spaces in module verification taint message

The warning message when loading modules with a wrong signature has
two spaces in it:

"module verification failed: signature and/or required key missing"

Signed-off-by: Marcel Holtmann <[email protected]>
---
kernel/module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/module.c b/kernel/module.c
index e52a8739361a..57f786bae64d 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3242,7 +3242,7 @@ static int load_module(struct load_info *info, const char __user *uargs,
mod->sig_ok = info->sig_ok;
if (!mod->sig_ok) {
pr_notice_once("%s: module verification failed: signature "
- "and/or required key missing - tainting "
+ "and/or required key missing - tainting "
"kernel\n", mod->name);
add_taint_module(mod, TAINT_UNSIGNED_MODULE, LOCKDEP_STILL_OK);
}
--
2.1.0

2014-12-23 22:26:44

by Rusty Russell

Subject: Re: [PATCH] module: Remove double spaces in module verification taint message

Marcel Holtmann <[email protected]> writes:
> The warning message when loading modules with a wrong signature has
> two spaces in it:
>
> "module verification failed: signature and/or required key missing"
>
> Signed-off-by: Marcel Holtmann <[email protected]>

Rather trivial, but I've applied it.

Thanks,
Rusty.

> ---
> kernel/module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index e52a8739361a..57f786bae64d 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -3242,7 +3242,7 @@ static int load_module(struct load_info *info, const char __user *uargs,
> mod->sig_ok = info->sig_ok;
> if (!mod->sig_ok) {
> pr_notice_once("%s: module verification failed: signature "
> - "and/or required key missing - tainting "
> + "and/or required key missing - tainting "
> "kernel\n", mod->name);
> add_taint_module(mod, TAINT_UNSIGNED_MODULE, LOCKDEP_STILL_OK);
> }
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/