2014-04-09 01:50:00

by Namhyung Kim

[permalink] [raw]
Subject: Re: [PATCH 1/2] perf, tools, stat: Initialize statistics correctly

On Tue, 25 Mar 2014 10:31:38 -0700, Andi Kleen wrote:
> From: Andi Kleen <[email protected]>
>
> perf stat did initialize the stats structure used to compute
> stddev etc. incorrectly. It merely zeroes it. But one member
> (min) needs to be set to a non zero value. This causes min
> to be not computed at all. Call init_stats() correctly.
>
> It doesn't matter for stat currently because it doesn't use
> min, but it's still better to do it correctly.
>
> The other users of statistics are already correct.

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung