2010-06-30 16:03:30

by Christoph Egger

Subject: [PATCH 30/33] Removing dead S3C_DEV_ADC

S3C_DEV_ADC doesn't exist in Kconfig, therefore removing all
references for it from the source code.

Signed-off-by: Christoph Egger <[email protected]>
---
arch/arm/mach-s5pv210/cpu.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c
index 411a4a9..c5d53ab 100644
--- a/arch/arm/mach-s5pv210/cpu.c
+++ b/arch/arm/mach-s5pv210/cpu.c
@@ -76,10 +76,6 @@ static void s5pv210_idle(void)

void __init s5pv210_map_io(void)
{
-#ifdef CONFIG_S3C_DEV_ADC
- s3c_device_adc.name = "s3c64xx-adc";
-#endif
-
iotable_init(s5pv210_iodesc, ARRAY_SIZE(s5pv210_iodesc));

/* initialise device information early */
--
1.7.0.4

2010-06-30 16:26:45

by Arnaud Patard

Subject: Re: [PATCH 30/33] Removing dead S3C_DEV_ADC

Christoph Egger <[email protected]> writes:

> S3C_DEV_ADC doesn't exist in Kconfig, therefore removing all
> references for it from the source code.
>
> Signed-off-by: Christoph Egger <[email protected]>
> ---
> arch/arm/mach-s5pv210/cpu.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c
> index 411a4a9..c5d53ab 100644
> --- a/arch/arm/mach-s5pv210/cpu.c
> +++ b/arch/arm/mach-s5pv210/cpu.c
> @@ -76,10 +76,6 @@ static void s5pv210_idle(void)
>
> void __init s5pv210_map_io(void)
> {
> -#ifdef CONFIG_S3C_DEV_ADC
> - s3c_device_adc.name = "s3c64xx-adc";
> -#endif
> -

too bad, should have been SAMSUNG_DEV_ADC :(
Anyway, a patch called "[PATCH] ARM: SAMSUNG: Implement set_name
function for ADC devices" has been sent for review today and is
addressing this same issue.

Thanks,
Arnaud

2010-07-02 10:18:59

by Ben Dooks

Subject: Re: [PATCH 30/33] Removing dead S3C_DEV_ADC

On 30/06/10 17:03, Christoph Egger wrote:
> S3C_DEV_ADC doesn't exist in Kconfig, therefore removing all
> references for it from the source code.

This is going to be fixed in the next kernel release, one way
or the other, so please drop this patch

--
Ben