2004-11-27 00:46:13

by Tobias DiPasquale

[permalink] [raw]
Subject: [PATCH][REVISED] add list_del_head[_init] functions

Hi all,

I revised my earlier list_del_head patch and took Jens' suggestions.
There were two function additions:

list_del_head() - removes the head of a list and returns it
list_del_head_init() - removes the head of a list, reinitializes it
and returns it

I have also converted several obvious pieces of code in kernel/, net/
and mm/ to use these new functions. The patch for all of this is
attached. Thanks :)

Name: Add list_del_head[_init] functions for full queue API
Status: Tested (smoke tests, mostly)
Signed-off-by: Toby DiPasquale <[email protected]>

P.S. Again, please CC me on any replies as I'm not subscribed to LKML.
Thanks again :)

--
[ Tobias DiPasquale ]
0x636f6465736c696e67657240676d61696c2e636f6d


Attachments:
(No filename) (726.00 B)
listdelhead.patch (9.53 kB)
Download all attachments

2004-11-27 01:16:59

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH][REVISED] add list_del_head[_init] functions

Tobias DiPasquale wrote:
> Hi all,
>
> I revised my earlier list_del_head patch and took Jens' suggestions.
> There were two function additions:
>
> list_del_head() - removes the head of a list and returns it
> list_del_head_init() - removes the head of a list, reinitializes it
> and returns it
>
> I have also converted several obvious pieces of code in kernel/, net/
> and mm/ to use these new functions. The patch for all of this is
> attached. Thanks :)
>
> Name: Add list_del_head[_init] functions for full queue API
> Status: Tested (smoke tests, mostly)
> Signed-off-by: Toby DiPasquale <[email protected]>
>
> P.S. Again, please CC me on any replies as I'm not subscribed to LKML.
> Thanks again :)
>

The net_rx_action one doesn't look right.

- Arnaldo

2004-11-27 02:30:34

by Tobias DiPasquale

[permalink] [raw]
Subject: Re: [PATCH][REVISED] add list_del_head[_init] functions

On Fri, 26 Nov 2004 22:13:23 -0200, Arnaldo Carvalho de Melo
<[email protected]> wrote:
> The net_rx_action one doesn't look right.

You're right. The deletion from the list is conditional. That's
removed in the attached patch.

Signed-off-by: Toby DiPasquale <[email protected]>

--
[ Tobias DiPasquale ]
0x636f6465736c696e67657240676d61696c2e636f6d


Attachments:
(No filename) (360.00 B)
listdelhead.patch (9.04 kB)
Download all attachments