2024-03-22 08:30:21

by Thomas Zimmermann

Subject: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus

Framebuffer I/O on the Sparc Sbus requires read/write helpers for
I/O memory. Select FB_IOMEM_FOPS accordingly.

Reported-by: Nick Bowler <[email protected]>
Closes: https://lore.kernel.org/lkml/[email protected]/
Signed-off-by: Thomas Zimmermann <[email protected]>
Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations")
Cc: Thomas Zimmermann <[email protected]>
Cc: Javier Martinez Canillas <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Helge Deller <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: <[email protected]> # v6.8+
---
drivers/video/fbdev/Kconfig | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index a61b8260b8f36..edced74f0eeaf 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -494,6 +494,7 @@ config FB_SBUS_HELPERS
select FB_CFB_COPYAREA
select FB_CFB_FILLRECT
select FB_CFB_IMAGEBLIT
+ select FB_IOMEM_FOPS

config FB_BW2
bool "BWtwo support"
@@ -514,6 +515,7 @@ config FB_CG6
depends on (FB = y) && (SPARC && FB_SBUS)
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
+ select FB_IOMEM_FOPS
help
This is the frame buffer device driver for the CGsix (GX, TurboGX)
frame buffer.
@@ -523,6 +525,7 @@ config FB_FFB
depends on FB_SBUS && SPARC64
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
+ select FB_IOMEM_FOPS
help
This is the frame buffer device driver for the Creator, Creator3D,
and Elite3D graphics boards.
--
2.44.0

2024-03-22 10:44:24

by Javier Martinez Canillas

Subject: Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus

Thomas Zimmermann <[email protected]> writes:

> Framebuffer I/O on the Sparc Sbus requires read/write helpers for
> I/O memory. Select FB_IOMEM_FOPS accordingly.
>
> Reported-by: Nick Bowler <[email protected]>
> Closes: https://lore.kernel.org/lkml/[email protected]/
> Signed-off-by: Thomas Zimmermann <[email protected]>
> Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations")
> Cc: Thomas Zimmermann <[email protected]>
> Cc: Javier Martinez Canillas <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Helge Deller <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: <[email protected]> # v6.8+
> ---

Reviewed-by: Javier Martinez Canillas <[email protected]>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

2024-03-23 06:59:33

by Sam Ravnborg

Subject: Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus

On Fri, Mar 22, 2024 at 09:29:46AM +0100, Thomas Zimmermann wrote:
> Framebuffer I/O on the Sparc Sbus requires read/write helpers for
> I/O memory. Select FB_IOMEM_FOPS accordingly.
>
> Reported-by: Nick Bowler <[email protected]>
> Closes: https://lore.kernel.org/lkml/[email protected]/
> Signed-off-by: Thomas Zimmermann <[email protected]>
> Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations")
> Cc: Thomas Zimmermann <[email protected]>
> Cc: Javier Martinez Canillas <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Helge Deller <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: <[email protected]> # v6.8+
Reviewed-by: Sam Ravnborg <[email protected]>

2024-03-23 11:25:19

by Nick Bowler

Subject: Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus

On 2024-03-22 06:43, Javier Martinez Canillas wrote:
> Thomas Zimmermann <[email protected]> writes:
>
>> Framebuffer I/O on the Sparc Sbus requires read/write helpers for
>> I/O memory. Select FB_IOMEM_FOPS accordingly.
>>
>> Reported-by: Nick Bowler <[email protected]>

Applied on top of 6.8 and the build is successful.

Thanks,
Nick

2024-03-26 01:13:56

by Thomas Zimmermann

Subject: Re: [PATCH] fbdev: Select I/O-memory framebuffer ops for SBus

Merged into drm-misc-fixes.

Am 22.03.24 um 09:29 schrieb Thomas Zimmermann:
> Framebuffer I/O on the Sparc Sbus requires read/write helpers for
> I/O memory. Select FB_IOMEM_FOPS accordingly.
>
> Reported-by: Nick Bowler <[email protected]>
> Closes: https://lore.kernel.org/lkml/[email protected]/
> Signed-off-by: Thomas Zimmermann <[email protected]>
> Fixes: 8813e86f6d82 ("fbdev: Remove default file-I/O implementations")
> Cc: Thomas Zimmermann <[email protected]>
> Cc: Javier Martinez Canillas <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Helge Deller <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: <[email protected]> # v6.8+
> ---
> drivers/video/fbdev/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index a61b8260b8f36..edced74f0eeaf 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -494,6 +494,7 @@ config FB_SBUS_HELPERS
> select FB_CFB_COPYAREA
> select FB_CFB_FILLRECT
> select FB_CFB_IMAGEBLIT
> + select FB_IOMEM_FOPS
>
> config FB_BW2
> bool "BWtwo support"
> @@ -514,6 +515,7 @@ config FB_CG6
> depends on (FB = y) && (SPARC && FB_SBUS)
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> + select FB_IOMEM_FOPS
> help
> This is the frame buffer device driver for the CGsix (GX, TurboGX)
> frame buffer.
> @@ -523,6 +525,7 @@ config FB_FFB
> depends on FB_SBUS && SPARC64
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> + select FB_IOMEM_FOPS
> help
> This is the frame buffer device driver for the Creator, Creator3D,
> and Elite3D graphics boards.

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)