2023-10-24 05:44:36

by Arnd Bergmann

Subject: [PATCH] vgacon: fix mips/sibyte build regression

From: Arnd Bergmann <[email protected]>

The conversion to vgacon_register_screen() was missing an #include statement
for the swarm board:

arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration]

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: 555624c0d10b vgacon: clean up global screen_info instances
Signed-off-by: Arnd Bergmann <[email protected]>
---
arch/mips/sibyte/swarm/setup.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/mips/sibyte/swarm/setup.c b/arch/mips/sibyte/swarm/setup.c
index 74e7c242b690..38c90b5e8754 100644
--- a/arch/mips/sibyte/swarm/setup.c
+++ b/arch/mips/sibyte/swarm/setup.c
@@ -13,6 +13,7 @@
#include <linux/memblock.h>
#include <linux/init.h>
#include <linux/kernel.h>
+#include <linux/console.h>
#include <linux/screen_info.h>
#include <linux/initrd.h>

--
2.39.2

2023-10-24 07:29:26

by Javier Martinez Canillas

Subject: Re: [PATCH] vgacon: fix mips/sibyte build regression

Arnd Bergmann <[email protected]> writes:

Hello Arnd,

> From: Arnd Bergmann <[email protected]>
>
> The conversion to vgacon_register_screen() was missing an #include statement
> for the swarm board:
>
> arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration]
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 555624c0d10b vgacon: clean up global screen_info instances
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---

Loos good to me.

Reviewed-by: Javier Martinez Canillas <[email protected]>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

2023-10-25 12:56:53

by Philippe Mathieu-Daudé

Subject: Re: [PATCH] vgacon: fix mips/sibyte build regression

On 24/10/23 07:44, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The conversion to vgacon_register_screen() was missing an #include statement
> for the swarm board:
>
> arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration]
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 555624c0d10b vgacon: clean up global screen_info instances
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> arch/mips/sibyte/swarm/setup.c | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>