2023-01-23 08:03:35

by Krzysztof Kozlowski

Subject: Re: [PATCH 03/15] dt-bindings: arm: ambarella: Add binding for Ambarella ARM platforms

On 23/01/2023 08:32, Li Chen wrote:
> This introduces binding for Ambarella s6lm SoC.
>
> Signed-off-by: Li Chen <[email protected]>
> Change-Id: Id95d91218625a1f0b3413aac101c2ca8831f0385

Please run scripts/checkpatch.pl and fix reported warnings.

> ---
> .../devicetree/bindings/arm/ambarella.yaml | 22 +++++++++++++++++++
> MAINTAINERS | 6 +++++
> 2 files changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/ambarella.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/ambarella.yaml b/Documentation/devicetree/bindings/arm/ambarella.yaml
> new file mode 100644
> index 000000000000..2c8ff75b57b9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/ambarella.yaml
> @@ -0,0 +1,22 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/ambarella.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ambarella SoC Device Tree Bindings

Drop "Device Tree Bindings"

> +
> +maintainers:
> + - Li Chen <[email protected]>
> +
> +properties:
> + $nodename:
> + const: "/"
> + compatible:
> + oneOf:
> + - description: Ambarella SoC based platforms
> + items:
> + - enum:
> + - ambarella,s6lm


Best regards,
Krzysztof

2023-01-23 14:00:03

by Li Chen

Subject: Re: [PATCH 03/15] dt-bindings: arm: ambarella: Add binding for Ambarella ARM platforms

On Mon, 23 Jan 2023 16:03:27 +0800,
Krzysztof Kozlowski wrote:
>
> On 23/01/2023 08:32, Li Chen wrote:
> > This introduces binding for Ambarella s6lm SoC.
> >
> > Signed-off-by: Li Chen <[email protected]>
> > Change-Id: Id95d91218625a1f0b3413aac101c2ca8831f0385
>
> Please run scripts/checkpatch.pl and fix reported warnings.

Sorry for it, I do run checkpatch & sparse and fix issues, but forget to remove the
Change-id finally, will remove it in v2.

> > ---
> > .../devicetree/bindings/arm/ambarella.yaml | 22 +++++++++++++++++++
> > MAINTAINERS | 6 +++++
> > 2 files changed, 28 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/arm/ambarella.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/ambarella.yaml b/Documentation/devicetree/bindings/arm/ambarella.yaml
> > new file mode 100644
> > index 000000000000..2c8ff75b57b9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/ambarella.yaml
> > @@ -0,0 +1,22 @@
> > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/ambarella.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Ambarella SoC Device Tree Bindings
>
> Drop "Device Tree Bindings"

Well noted.

> > +
> > +maintainers:
> > + - Li Chen <[email protected]>
> > +
> > +properties:
> > + $nodename:
> > + const: "/"
> > + compatible:
> > + oneOf:
> > + - description: Ambarella SoC based platforms
> > + items:
> > + - enum:
> > + - ambarella,s6lm

Thanks for your review!

Regards,
Li