2021-07-31 17:22:57

by Salah Triki

Subject: [PATCH] usb: gadget: remove useless cast

Remove the cast done by ERR_PTR() and PTR_ERR() since data is of type char
* and fss_prepare_buffer() should returns a value of this type.

Signed-off-by: Salah Triki <[email protected]>
---
drivers/usb/gadget/function/f_fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
index 9c0c393abb39..e411555e4c34 100644
--- a/drivers/usb/gadget/function/f_fs.c
+++ b/drivers/usb/gadget/function/f_fs.c
@@ -3831,7 +3831,7 @@ static char *ffs_prepare_buffer(const char __user *buf, size_t len)

data = memdup_user(buf, len);
if (IS_ERR(data))
- return ERR_PTR(PTR_ERR(data));
+ return data;

pr_vdebug("Buffer from user space:\n");
ffs_dump_mem("", data, len);
--
2.25.1

2021-08-02 08:28:40

by Felipe Balbi

Subject: Re: [PATCH] usb: gadget: remove useless cast

Salah Triki <[email protected]> writes:

> Remove the cast done by ERR_PTR() and PTR_ERR() since data is of type char
> * and fss_prepare_buffer() should returns a value of this type.
>
> Signed-off-by: Salah Triki <[email protected]>

Acked-by: Felipe Balbi <[email protected]>

--
balbi