2019-10-21 11:46:40

by Yi Wang

Subject: [PATCH] net: sched: taprio: fix -Wmissing-prototypes warnings

We get one warnings when build kernel W=1:
net/sched/sch_taprio.c:1155:6: warning: no previous prototype for ‘taprio_offload_config_changed’ [-Wmissing-prototypes]

Make the function static to fix this.

Signed-off-by: Yi Wang <[email protected]>
---
net/sched/sch_taprio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 6719a65..2121187 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1152,7 +1152,7 @@ void taprio_offload_free(struct tc_taprio_qopt_offload *offload)
* offload state (PENDING, ACTIVE, INACTIVE) so it can be visible in dump().
* This is left as TODO.
*/
-void taprio_offload_config_changed(struct taprio_sched *q)
+static void taprio_offload_config_changed(struct taprio_sched *q)
{
struct sched_gate_list *oper, *admin;

--
1.8.3.1

2019-10-21 21:22:29

by Vinicius Costa Gomes

Subject: Re: [PATCH] net: sched: taprio: fix -Wmissing-prototypes warnings

Hi,

Yi Wang <[email protected]> writes:

> We get one warnings when build kernel W=1:
> net/sched/sch_taprio.c:1155:6: warning: no previous prototype for ‘taprio_offload_config_changed’ [-Wmissing-prototypes]
>
> Make the function static to fix this.
>
> Signed-off-by: Yi Wang <[email protected]>
> ---

This looks like it should be directed to net-next.

When you re-send it for net-next, feel free to add my:

Acked-by: Vinicius Costa Gomes <[email protected]>


Cheers,
--
Vinicius