2019-06-17 11:19:37

by Toke Høiland-Jørgensen

Subject: Re: [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup

Anton Protopopov <[email protected]> writes:

> The bpf_ipv6_fib_lookup function should return BPF_FIB_LKUP_RET_FWD_DISABLED
> when forwarding is disabled for the input device. However instead of checking
> if forwarding is enabled on the input device, it checked the global
> net->ipv6.devconf_all->forwarding flag. Change it to behave as expected.
>
> Signed-off-by: Anton Protopopov <[email protected]>

Thanks!

Acked-by: Toke Høiland-Jørgensen <[email protected]>

2019-06-17 14:15:07

by David Ahern

Subject: Re: [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup

On 6/17/19 5:17 AM, Toke Høiland-Jørgensen wrote:
> Anton Protopopov <[email protected]> writes:
>
>> The bpf_ipv6_fib_lookup function should return BPF_FIB_LKUP_RET_FWD_DISABLED
>> when forwarding is disabled for the input device. However instead of checking
>> if forwarding is enabled on the input device, it checked the global
>> net->ipv6.devconf_all->forwarding flag. Change it to behave as expected.
>>
>> Signed-off-by: Anton Protopopov <[email protected]>
>
> Thanks!
>
> Acked-by: Toke Høiland-Jørgensen <[email protected]>
>

Fixes: 87f5fc7e48dd ("bpf: Provide helper to do forwarding lookups in
kernel FIB table")

Reviewed-by: David Ahern <[email protected]>