2019-01-29 08:05:32

by Yue Haibing

Subject: [PATCH -next] ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data"

Since commit 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
kfree, iounmap, clk_put etc no need do any more in remove path.

Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
Signed-off-by: YueHaibing <[email protected]>
---
arch/arm/plat-pxa/ssp.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index ed36dca..bf25f78 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -183,25 +183,16 @@ static int pxa_ssp_probe(struct platform_device *pdev)

static int pxa_ssp_remove(struct platform_device *pdev)
{
- struct resource *res;
struct ssp_device *ssp;

ssp = platform_get_drvdata(pdev);
if (ssp == NULL)
return -ENODEV;

- iounmap(ssp->mmio_base);
-
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- release_mem_region(res->start, resource_size(res));
-
- clk_put(ssp->clk);
-
mutex_lock(&ssp_lock);
list_del(&ssp->node);
mutex_unlock(&ssp_lock);

- kfree(ssp);
return 0;
}

--
2.7.0

2019-02-16 07:16:43

by Robert Jarzmik

Subject: Re: [PATCH -next] ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data"

YueHaibing <[email protected]> writes:

> Since commit 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
> kfree, iounmap, clk_put etc no need do any more in remove path.
>
> Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
> Signed-off-by: YueHaibing <[email protected]>
Sorry for the late reply, I had forgotten to answer.

Queued to pxa/for-next with a small spelling fix in the commit message, thanks.

Cheers.

--
Robert