2020-03-28 09:49:16

by Nishad Kamdar

[permalink] [raw]
Subject: [PATCH] USB: dwc2: Use the correct style for SPDX License Identifier

This patch corrects the SPDX License Identifier style in
header files related to DesignWare USB2 DRD Core Support.
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used).

Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.

Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Nishad Kamdar <[email protected]>
---
drivers/usb/dwc2/core.h | 2 +-
drivers/usb/dwc2/debug.h | 2 +-
drivers/usb/dwc2/hcd.h | 2 +-
drivers/usb/dwc2/hw.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index 99b0bdfe0012..668d1ad646a4 100644
--- a/drivers/usb/dwc2/core.h
+++ b/drivers/usb/dwc2/core.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
/*
* core.h - DesignWare HS OTG Controller common declarations
*
diff --git a/drivers/usb/dwc2/debug.h b/drivers/usb/dwc2/debug.h
index a8c565b6bc34..47252c56d410 100644
--- a/drivers/usb/dwc2/debug.h
+++ b/drivers/usb/dwc2/debug.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* debug.h - Designware USB2 DRD controller debug header
*
diff --git a/drivers/usb/dwc2/hcd.h b/drivers/usb/dwc2/hcd.h
index 1224fa9df604..ea02ee63ac6d 100644
--- a/drivers/usb/dwc2/hcd.h
+++ b/drivers/usb/dwc2/hcd.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
/*
* hcd.h - DesignWare HS OTG Controller host-mode declarations
*
diff --git a/drivers/usb/dwc2/hw.h b/drivers/usb/dwc2/hw.h
index c4027bbcedec..864b76a0b954 100644
--- a/drivers/usb/dwc2/hw.h
+++ b/drivers/usb/dwc2/hw.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
/*
* hw.h - DesignWare HS OTG Controller hardware definitions
*
--
2.17.1


2020-04-09 08:35:42

by Minas Harutyunyan

[permalink] [raw]
Subject: Re: [PATCH] USB: dwc2: Use the correct style for SPDX License Identifier



On 3/28/2020 1:48 PM, Nishad Kamdar wrote:
> This patch corrects the SPDX License Identifier style in
> header files related to DesignWare USB2 DRD Core Support.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
>
> Changes made by using a script provided by Joe Perches here:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2019_2_7_46&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=cQBKt4q-qzNVC53rNAwuwplH23V61rHQhhULvdLA0U8&m=0j9MsigL2x2AKk9HPbMC-dIRhfe2-TejlnFiyg-hjLo&s=hkvODF0-Bem5UE233QP8PJ8-E2NhnO3kdDi6euKBIMI&e= .
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Nishad Kamdar <[email protected]>

Acked-by: Minas Harutyunyan <[email protected]>

> ---
> drivers/usb/dwc2/core.h | 2 +-
> drivers/usb/dwc2/debug.h | 2 +-
> drivers/usb/dwc2/hcd.h | 2 +-
> drivers/usb/dwc2/hw.h | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
> index 99b0bdfe0012..668d1ad646a4 100644
> --- a/drivers/usb/dwc2/core.h
> +++ b/drivers/usb/dwc2/core.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
> /*
> * core.h - DesignWare HS OTG Controller common declarations
> *
> diff --git a/drivers/usb/dwc2/debug.h b/drivers/usb/dwc2/debug.h
> index a8c565b6bc34..47252c56d410 100644
> --- a/drivers/usb/dwc2/debug.h
> +++ b/drivers/usb/dwc2/debug.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * debug.h - Designware USB2 DRD controller debug header
> *
> diff --git a/drivers/usb/dwc2/hcd.h b/drivers/usb/dwc2/hcd.h
> index 1224fa9df604..ea02ee63ac6d 100644
> --- a/drivers/usb/dwc2/hcd.h
> +++ b/drivers/usb/dwc2/hcd.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
> /*
> * hcd.h - DesignWare HS OTG Controller host-mode declarations
> *
> diff --git a/drivers/usb/dwc2/hw.h b/drivers/usb/dwc2/hw.h
> index c4027bbcedec..864b76a0b954 100644
> --- a/drivers/usb/dwc2/hw.h
> +++ b/drivers/usb/dwc2/hw.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
> /*
> * hw.h - DesignWare HS OTG Controller hardware definitions
> *
>