2024-04-01 20:59:18

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the sound-current tree

Hi all,

In commit

e1d8acf35ce7 ("Revert "ALSA: emu10k1: fix synthesizer sample playback position and caching"")

Fixes tag

Fixes: df335e9a8b (ALSA: emu10k1: fix synthesizer sample playback position and caching, 2023-05-18)

has these problem(s):

- SHA1 should be at least 12 digits long
This can be fixed for the future by setting core.abbrev to 12 (or
more) or (for git v2.11 or later) just making sure it is not set
(or set to "auto").
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

The date field adds nothing.

Thus:

Fixes: df335e9a8bcb ("ALSA: emu10k1: fix synthesizer sample playback position and caching")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2024-04-02 05:56:56

by Takashi Iwai

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the sound-current tree

On Mon, 01 Apr 2024 22:58:53 +0200,
Stephen Rothwell wrote:
>
> Hi all,
>
> In commit
>
> e1d8acf35ce7 ("Revert "ALSA: emu10k1: fix synthesizer sample playback position and caching"")
>
> Fixes tag
>
> Fixes: df335e9a8b (ALSA: emu10k1: fix synthesizer sample playback position and caching, 2023-05-18)
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> This can be fixed for the future by setting core.abbrev to 12 (or
> more) or (for git v2.11 or later) just making sure it is not set
> (or set to "auto").
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> The date field adds nothing.
>
> Thus:
>
> Fixes: df335e9a8bcb ("ALSA: emu10k1: fix synthesizer sample playback position and caching")

The commit is corrected now. Thanks.


Takashi