2023-07-10 03:53:59

by Zhang, Rui

Subject: [PATCH] cpu/SMT: Fix cpu_smt_possible() comment

The comment of cpu_smt_possible() is not aligned with the changelog of
commit e1572f1d08be ("cpu/SMT: create and export cpu_smt_possible()"),
and it is wrong.

Fix cpu_smt_possible() comment.

Signed-off-by: Zhang Rui <[email protected]>
---
kernel/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index 7e8f1b044772..f6811c857102 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -676,7 +676,7 @@ static inline bool cpu_smt_allowed(unsigned int cpu)
return !cpumask_test_cpu(cpu, &cpus_booted_once_mask);
}

-/* Returns true if SMT is not supported of forcefully (irreversibly) disabled */
+/* Returns true if SMT is supported and not forcefully (irreversibly) disabled */
bool cpu_smt_possible(void)
{
return cpu_smt_control != CPU_SMT_FORCE_DISABLED &&
--
2.34.1

2023-07-10 08:06:24

by Vitaly Kuznetsov

Subject: Re: [PATCH] cpu/SMT: Fix cpu_smt_possible() comment

Zhang Rui <[email protected]> writes:

> The comment of cpu_smt_possible() is not aligned with the changelog of
> commit e1572f1d08be ("cpu/SMT: create and export cpu_smt_possible()"),
> and it is wrong.
>
> Fix cpu_smt_possible() comment.
>
> Signed-off-by: Zhang Rui <[email protected]>
> ---
> kernel/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 7e8f1b044772..f6811c857102 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -676,7 +676,7 @@ static inline bool cpu_smt_allowed(unsigned int cpu)
> return !cpumask_test_cpu(cpu, &cpus_booted_once_mask);
> }
>
> -/* Returns true if SMT is not supported of forcefully (irreversibly) disabled */
> +/* Returns true if SMT is supported and not forcefully (irreversibly) disabled */
> bool cpu_smt_possible(void)
> {
> return cpu_smt_control != CPU_SMT_FORCE_DISABLED &&

The function must've had a different name in an earlier version of the
patch...

Thanks for catching this!

Reviewed-by: Vitaly Kuznetsov <[email protected]>

--
Vitaly

2023-07-28 07:59:31

by Thomas Gleixner

Subject: Re: [PATCH] cpu/SMT: Fix cpu_smt_possible() comment

On Mon, Jul 10 2023 at 11:21, Zhang Rui wrote:
> The comment of cpu_smt_possible() is not aligned with the changelog of
> commit e1572f1d08be ("cpu/SMT: create and export cpu_smt_possible()"),
> and it is wrong.

Why? Do I need to go and read that commit log and figure out what's wrong?

> Fix cpu_smt_possible() comment.

Zero information.

2023-07-28 16:49:44

by Zhang, Rui

Subject: Re: [PATCH] cpu/SMT: Fix cpu_smt_possible() comment

Hi, Thomas,

On Fri, 2023-07-28 at 09:34 +0200, Thomas Gleixner wrote:
> On Mon, Jul 10 2023 at 11:21, Zhang Rui wrote:
> > The comment of cpu_smt_possible() is not aligned with the changelog
> > of
> > commit e1572f1d08be ("cpu/SMT: create and export
> > cpu_smt_possible()"),
> > and it is wrong.
>
> Why? Do I need to go and read that commit log and figure out what's
> wrong?
>
> > Fix cpu_smt_possible() comment.
>
> Zero information.
>
Thanks for reviewing. Sent patch V2 with changelog rephrased.

thanks,
rui