2023-01-13 07:24:01

by Randy Dunlap

Subject: [PATCH] Input: synaptics-rmi4: use correct function name in kernel-doc

Use the correct function name in kernel-doc notation to prevent a warning:

drivers/input/rmi4/rmi_bus.c:300: warning: expecting prototype for rmi_register_function_handler(). Prototype was for __rmi_register_function_handler() instead

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Dmitry Torokhov <[email protected]>
Cc: [email protected]
---
drivers/input/rmi4/rmi_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
--- a/drivers/input/rmi4/rmi_bus.c
+++ b/drivers/input/rmi4/rmi_bus.c
@@ -285,7 +285,7 @@ void rmi_unregister_function(struct rmi_
}

/**
- * rmi_register_function_handler - register a handler for an RMI function
+ * __rmi_register_function_handler - register a handler for an RMI function
* @handler: RMI handler that should be registered.
* @owner: pointer to module that implements the handler
* @mod_name: name of the module implementing the handler

2023-01-24 09:39:25

by Mattijs Korpershoek

Subject: Re: [PATCH] Input: synaptics-rmi4: use correct function name in kernel-doc

On Thu, Jan 12, 2023 at 22:38, Randy Dunlap <[email protected]> wrote:

> Use the correct function name in kernel-doc notation to prevent a warning:
>
> drivers/input/rmi4/rmi_bus.c:300: warning: expecting prototype for rmi_register_function_handler(). Prototype was for __rmi_register_function_handler() instead
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Dmitry Torokhov <[email protected]>
> Cc: [email protected]

Reviewed-by: Mattijs Korpershoek <[email protected]>

> ---
> drivers/input/rmi4/rmi_bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
> --- a/drivers/input/rmi4/rmi_bus.c
> +++ b/drivers/input/rmi4/rmi_bus.c
> @@ -285,7 +285,7 @@ void rmi_unregister_function(struct rmi_
> }
>
> /**
> - * rmi_register_function_handler - register a handler for an RMI function
> + * __rmi_register_function_handler - register a handler for an RMI function
> * @handler: RMI handler that should be registered.
> * @owner: pointer to module that implements the handler
> * @mod_name: name of the module implementing the handler