2022-06-13 17:42:09

by Srinivas Neeli

Subject: [PATCH V8 2/3] rtc: zynqmp: Updated calibration value

As per RTC spec default calibration value is 0x7FFF.

Signed-off-by: Srinivas Neeli <[email protected]>
---
Changes in V8
-None, just swapped 2/3 and 3/3 patches from V7.
Changes in V7:
-New patch
-TRM not updated yet, Internal design document contains 0x7FFF as
default value. TRM Will update in next release.
---
drivers/rtc/rtc-zynqmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c
index f440bb52be92..5da33d760419 100644
--- a/drivers/rtc/rtc-zynqmp.c
+++ b/drivers/rtc/rtc-zynqmp.c
@@ -36,7 +36,7 @@
#define RTC_OSC_EN BIT(24)
#define RTC_BATT_EN BIT(31)

-#define RTC_CALIB_DEF 0x198233
+#define RTC_CALIB_DEF 0x7FFF
#define RTC_CALIB_MASK 0x1FFFFF
#define RTC_ALRM_MASK BIT(1)
#define RTC_MSEC 1000
--
2.25.1

2022-06-14 11:55:23

by Peter Korsgaard

Subject: Re: [PATCH V8 2/3] rtc: zynqmp: Updated calibration value

>>>>> "Srinivas" == Srinivas Neeli <[email protected]> writes:

> As per RTC spec default calibration value is 0x7FFF.
> Signed-off-by: Srinivas Neeli <[email protected]>

> ---
> Changes in V8
> -None, just swapped 2/3 and 3/3 patches from V7.
> Changes in V7:
> -New patch
> -TRM not updated yet, Internal design document contains 0x7FFF as
> default value. TRM Will update in next release.

Maybe add this to the commit message so it is clear where this comes
from. If possible specific the TRM version number that will contain the
fix.

Other than that:

Acked-by: Peter Korsgaard <[email protected]>

--
Bye, Peter Korsgaard