2019-08-10 05:01:54

by Gustavo A. R. Silva

Subject: [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement

Add missing break statement in order to prevent the code from
erroneously falling through to case SH_BREAKPOINT_WRITE.

Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
Cc: [email protected]
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---

If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.

arch/sh/kernel/hw_breakpoint.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
index 3bd010b4c55f..f10d64311127 100644
--- a/arch/sh/kernel/hw_breakpoint.c
+++ b/arch/sh/kernel/hw_breakpoint.c
@@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
switch (sh_type) {
case SH_BREAKPOINT_READ:
*gen_type = HW_BREAKPOINT_R;
+ break;
case SH_BREAKPOINT_WRITE:
*gen_type = HW_BREAKPOINT_W;
break;
--
2.22.0

2019-08-10 06:55:17

by Geert Uytterhoeven

Subject: Re: [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement

On Sat, Aug 10, 2019 at 6:59 AM Gustavo A. R. Silva
<[email protected]> wrote:
> Add missing break statement in order to prevent the code from
> erroneously falling through to case SH_BREAKPOINT_WRITE.
>
> Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
> Cc: [email protected]
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2019-08-10 12:56:36

by Guenter Roeck

Subject: Re: [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement

On Fri, Aug 09, 2019 at 11:59:44PM -0500, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from
> erroneously falling through to case SH_BREAKPOINT_WRITE.
>
> Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
> Cc: [email protected]
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>
Tested-by: Guenter Roeck <[email protected]>

> ---
>
> If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.
>
> arch/sh/kernel/hw_breakpoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
> index 3bd010b4c55f..f10d64311127 100644
> --- a/arch/sh/kernel/hw_breakpoint.c
> +++ b/arch/sh/kernel/hw_breakpoint.c
> @@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
> switch (sh_type) {
> case SH_BREAKPOINT_READ:
> *gen_type = HW_BREAKPOINT_R;
> + break;
> case SH_BREAKPOINT_WRITE:
> *gen_type = HW_BREAKPOINT_W;
> break;
> --
> 2.22.0
>

2019-08-13 10:33:39

by Yoshinori Sato

Subject: Re: [PATCH] sh: kernel: hw_breakpoint: Fix missing break in switch statement

On Sat, 10 Aug 2019 13:59:44 +0900,
Gustavo A. R. Silva wrote:
>
> Add missing break statement in order to prevent the code from
> erroneously falling through to case SH_BREAKPOINT_WRITE.
>
> Fixes: 09a072947791 ("sh: hw-breakpoints: Add preliminary support for SH-4A UBC.")
> Cc: [email protected]
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
>
> If no one cares, I'll apply this to my tree and queue it up for 5.3-rc4.
>
> arch/sh/kernel/hw_breakpoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
> index 3bd010b4c55f..f10d64311127 100644
> --- a/arch/sh/kernel/hw_breakpoint.c
> +++ b/arch/sh/kernel/hw_breakpoint.c
> @@ -157,6 +157,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
> switch (sh_type) {
> case SH_BREAKPOINT_READ:
> *gen_type = HW_BREAKPOINT_R;
> + break;
> case SH_BREAKPOINT_WRITE:
> *gen_type = HW_BREAKPOINT_W;
> break;
> --
> 2.22.0
>

Applied sh-next.
Thanks.

--
Yosinori Sato