2018-06-21 13:23:58

by Gustavo A. R. Silva

Subject: [PATCH] spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe

It seems that the proper structure field to use in this particular
case is *regmap_pushr* instead of regmap.

Addresses-Coverity-ID: 1470126 ("Copy-paste error")
Fixes: 58ba07ec79e6 ("spi: spi-fsl-dspi: Add support for XSPI mode registers")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/spi/spi-fsl-dspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index 1f85dcd..ff7456b 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -1066,7 +1066,7 @@ static int dspi_probe(struct platform_device *pdev)
dev_err(&pdev->dev,
"failed to init pushr regmap: %ld\n",
PTR_ERR(dspi->regmap_pushr));
- ret = PTR_ERR(dspi->regmap);
+ ret = PTR_ERR(dspi->regmap_pushr);
goto out_master_put;
}
}
--
2.7.4

2018-06-21 15:30:39

by Esben Haabendal

Subject: Re: [PATCH] spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe

"Gustavo A. R. Silva" <[email protected]> writes:

> It seems that the proper structure field to use in this particular
> case is *regmap_pushr* instead of regmap.
>
> Addresses-Coverity-ID: 1470126 ("Copy-paste error")
> Fixes: 58ba07ec79e6 ("spi: spi-fsl-dspi: Add support for XSPI mode registers")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/spi/spi-fsl-dspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
> index 1f85dcd..ff7456b 100644
> --- a/drivers/spi/spi-fsl-dspi.c
> +++ b/drivers/spi/spi-fsl-dspi.c
> @@ -1066,7 +1066,7 @@ static int dspi_probe(struct platform_device *pdev)
> dev_err(&pdev->dev,
> "failed to init pushr regmap: %ld\n",
> PTR_ERR(dspi->regmap_pushr));
> - ret = PTR_ERR(dspi->regmap);
> + ret = PTR_ERR(dspi->regmap_pushr);
> goto out_master_put;
> }
> }

Acked-by: Esben Haabendal <[email protected]>