2023-11-15 06:29:27

by José Pekkarinen

[permalink] [raw]
Subject: Re: [PATCH v2] drm/amd/display: fix NULL dereference

On 2023-11-14 23:01, Hamza Mahfooz wrote:
> On 11/14/23 10:27, José Pekkarinen wrote:
>> The following patch will fix a minor issue where a debug message is
>> referencing an struct that has just being checked whether is null or
>> not. This has been noticed by using coccinelle, in the following
>> output:
>>
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:540:25-29:
>> ERROR: aconnector is NULL but dereferenced.
>>
>> Fixes: 5d72e247e58c9 ("drm/amd/display: switch DC over to the new DRM
>> logging macros")
>
> You only need the first 12 characters of the hash here. I have fixed it
> for you and applied the patch in this case. But, in the future please
> test your patches against `./scripts/checkpatch.pl` before submitting
> them.

Oops! Sorry I didn't notice! Thanks!

José.