Hi Linus,
The TIF_NOTIFY_SIGNAL change inadvertently removed the unconditional
task_work run we had in get_signal(). This caused a regression for some
setups, since we're relying on eg ____fput() being run to close and
release, for example, a pipe and wake the other end. For 5.11, I prefer
the simple solution of just reinstating the unconditional run, even if
it conceptually doesn't make much sense - if you need that kind of
guarantee, you should be using TWA_SIGNAL instead of TWA_NOTIFY. But
it's the trivial fix for 5.11, and would ensure that other potential
gotchas/assumptions for task_work don't regress for 5.11.
we're looking into further simplifying the task_work notifications for
5.12 which would resolve that too.
Please pull!
The following changes since commit e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62:
Linux 5.11-rc2 (2021-01-03 15:55:30 -0800)
are available in the Git repository at:
git://git.kernel.dk/linux-block.git tags/task_work-2021-01-19
for you to fetch changes up to 35d0b389f3b23439ad15b610d6e43fc72fc75779:
task_work: unconditionally run task_work from get_signal() (2021-01-08 09:14:21 -0700)
----------------------------------------------------------------
task_work-2021-01-19
----------------------------------------------------------------
Jens Axboe (1):
task_work: unconditionally run task_work from get_signal()
kernel/signal.c | 3 +++
1 file changed, 3 insertions(+)
--
Jens Axboe
The pull request you sent on Tue, 19 Jan 2021 11:15:54 -0700:
> git://git.kernel.dk/linux-block.git tags/task_work-2021-01-19
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/45dfb8a5659ad286c28fa59008271dbc4e5e3f2d
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html