2024-02-04 09:02:51

by Masahiro Yamada

Subject: [PATCH] sound: remove duplicated CONFIG_SND_PXA2XX_AC97 entry

'config SND_PXA2XX_AC97' is already present in sound/arm/Kconfig with
a prompt.

Commit 734c2d4bb7cf ("[ALSA] ASoC pxa2xx build support") redundantly
added the second one to sound/soc/pxa/Kconfig.

Remove it.

Signed-off-by: Masahiro Yamada <[email protected]>
---

sound/soc/pxa/Kconfig | 3 ---
1 file changed, 3 deletions(-)

diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
index f03c74809324..e05d6ce4c8fa 100644
--- a/sound/soc/pxa/Kconfig
+++ b/sound/soc/pxa/Kconfig
@@ -8,9 +8,6 @@ config SND_PXA2XX_SOC
the PXA2xx AC97, I2S or SSP interface. You will also need
to select the audio interfaces to support below.

-config SND_PXA2XX_AC97
- tristate
-
config SND_PXA2XX_SOC_AC97
tristate "SoC AC97 support for PXA2xx"
depends on SND_PXA2XX_SOC
--
2.40.1

2024-02-04 09:05:20

by Masahiro Yamada

Subject: Re: [PATCH] sound: remove duplicated CONFIG_SND_PXA2XX_AC97 entry

Maybe, the patch subject "ASoC: pxa:" might be better than "sound:"
so it matches the change history in this directory.



On Sun, Feb 4, 2024 at 6:02 PM Masahiro Yamada <[email protected]> wrote:
>
> 'config SND_PXA2XX_AC97' is already present in sound/arm/Kconfig with
> a prompt.
>
> Commit 734c2d4bb7cf ("[ALSA] ASoC pxa2xx build support") redundantly
> added the second one to sound/soc/pxa/Kconfig.
>
> Remove it.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> sound/soc/pxa/Kconfig | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
> index f03c74809324..e05d6ce4c8fa 100644
> --- a/sound/soc/pxa/Kconfig
> +++ b/sound/soc/pxa/Kconfig
> @@ -8,9 +8,6 @@ config SND_PXA2XX_SOC
> the PXA2xx AC97, I2S or SSP interface. You will also need
> to select the audio interfaces to support below.
>
> -config SND_PXA2XX_AC97
> - tristate
> -
> config SND_PXA2XX_SOC_AC97
> tristate "SoC AC97 support for PXA2xx"
> depends on SND_PXA2XX_SOC
> --
> 2.40.1
>


--
Best Regards
Masahiro Yamada

2024-02-04 09:08:45

by Takashi Iwai

Subject: Re: [PATCH] sound: remove duplicated CONFIG_SND_PXA2XX_AC97 entry

On Sun, 04 Feb 2024 10:04:32 +0100,
Masahiro Yamada wrote:
>
> Maybe, the patch subject "ASoC: pxa:" might be better than "sound:"
> so it matches the change history in this directory.

Yes, care to resubmit with that prefix?


thanks,

Takashi

2024-02-04 09:14:06

by Masahiro Yamada

Subject: Re: [PATCH] sound: remove duplicated CONFIG_SND_PXA2XX_AC97 entry

On Sun, Feb 4, 2024 at 6:08 PM Takashi Iwai <[email protected]> wrote:
>
> On Sun, 04 Feb 2024 10:04:32 +0100,
> Masahiro Yamada wrote:
> >
> > Maybe, the patch subject "ASoC: pxa:" might be better than "sound:"
> > so it matches the change history in this directory.
>
> Yes, care to resubmit with that prefix?
>


Sure.


--
Best Regards
Masahiro Yamada