2022-04-21 08:38:05

by Andreas Schwab

Subject: Re: [PATCH v2 1/4] RISC-V: Avoid empty create_*_mapping definitions

On Apr 20 2022, Palmer Dabbelt wrote:

> (create_pmd_mpping() ends up skipped on XIP_KERNEL).

Does it? There is always the semicolon left as the body of the
conditional (which is why you get the empty-body warning in the first
place).

--
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."

2022-05-25 22:12:10

by Palmer Dabbelt

Subject: Re: [PATCH v2 1/4] RISC-V: Avoid empty create_*_mapping definitions

On Wed, 20 Apr 2022 15:11:37 PDT (-0700), [email protected] wrote:
> On Apr 20 2022, Palmer Dabbelt wrote:
>
>> (create_pmd_mpping() ends up skipped on XIP_KERNEL).
>
> Does it? There is always the semicolon left as the body of the
> conditional (which is why you get the empty-body warning in the first
> place).

Yep, you're right. I fixed up the commit message, thanks!