2021-03-25 20:10:25

by Randy Dunlap

Subject: [PATCH] selftests: powerpc: unmark non-kernel-doc comments

Drop the 'beginning of kernel-doc' notation markers (/**)
in places that are not in kernel-doc format.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: [email protected]
---
tools/testing/selftests/powerpc/tm/tm-trap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20210323.orig/tools/testing/selftests/powerpc/tm/tm-trap.c
+++ linux-next-20210323/tools/testing/selftests/powerpc/tm/tm-trap.c
@@ -66,7 +66,7 @@ void trap_signal_handler(int signo, sigi
/* Get thread endianness: extract bit LE from MSR */
thread_endianness = MSR_LE & ucp->uc_mcontext.gp_regs[PT_MSR];

- /***
+ /*
* Little-Endian Machine
*/

@@ -126,7 +126,7 @@ void trap_signal_handler(int signo, sigi
}
}

- /***
+ /*
* Big-Endian Machine
*/

2021-03-26 04:51:58

by Daniel Axtens

Subject: Re: [PATCH] selftests: powerpc: unmark non-kernel-doc comments

Randy Dunlap <[email protected]> writes:

> Drop the 'beginning of kernel-doc' notation markers (/**)
> in places that are not in kernel-doc format.

This looks good to me. Arguably we don't need the comments at all, but
it doesn't seem to hurt to keep them.

checkpatch is OK with the entire file, so there's nothing else we'd
really want to clean up while you're doing cleanups.

Reviewed-by: Daniel Axtens <[email protected]>

Kind regards,
Daniel

>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: [email protected]
> ---
> tools/testing/selftests/powerpc/tm/tm-trap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20210323.orig/tools/testing/selftests/powerpc/tm/tm-trap.c
> +++ linux-next-20210323/tools/testing/selftests/powerpc/tm/tm-trap.c
> @@ -66,7 +66,7 @@ void trap_signal_handler(int signo, sigi
> /* Get thread endianness: extract bit LE from MSR */
> thread_endianness = MSR_LE & ucp->uc_mcontext.gp_regs[PT_MSR];
>
> - /***
> + /*
> * Little-Endian Machine
> */
>
> @@ -126,7 +126,7 @@ void trap_signal_handler(int signo, sigi
> }
> }
>
> - /***
> + /*
> * Big-Endian Machine
> */
>

2021-03-31 01:13:46

by Michael Ellerman

Subject: Re: [PATCH] selftests: powerpc: unmark non-kernel-doc comments

On Thu, 25 Mar 2021 13:08:20 -0700, Randy Dunlap wrote:
> Drop the 'beginning of kernel-doc' notation markers (/**)
> in places that are not in kernel-doc format.

Applied to powerpc/next.

[1/1] selftests: powerpc: unmark non-kernel-doc comments
https://git.kernel.org/powerpc/c/dfc4ae3372182a168146745def03d877f31fcf2f

cheers