2020-12-02 04:28:05

by Nobuhiro Iwamatsu

Subject: [PATCH] arm64: dts: visconti: Add watchdog support for TMPV7708 SoC

Add watchdog node in TMPV7708's dtsi, and tmpv7708-rm-mbrc boards's
dts.

Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
---
arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts | 5 +++++
arch/arm64/boot/dts/toshiba/tmpv7708.dtsi | 12 ++++++++++++
2 files changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
index ed0bf7f13f54..37da418393e0 100644
--- a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
+++ b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
@@ -41,3 +41,8 @@ &uart1 {
clocks = <&uart_clk>;
clock-names = "apb_pclk";
};
+
+&wdt {
+ status = "okay";
+ clocks = <&wdt_clk>;
+};
diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
index 242f25f4e12a..c360e68bef1d 100644
--- a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
+++ b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
@@ -134,6 +134,12 @@ uart_clk: uart-clk {
#clock-cells = <0>;
};

+ wdt_clk: wdt-clk {
+ compatible = "fixed-clock";
+ clock-frequency = <150000000>;
+ #clock-cells = <0>;
+ };
+
soc {
#address-cells = <2>;
#size-cells = <2>;
@@ -384,6 +390,12 @@ spi6: spi@28146000 {
#size-cells = <0>;
status = "disabled";
};
+
+ wdt: wdt@28330000 {
+ compatible = "toshiba,visconti-wdt";
+ reg = <0 0x28330000 0 0x1000>;
+ status = "disabled";
+ };
};
};

--
2.29.2

2020-12-03 10:20:17

by Punit Agrawal

Subject: Re: [PATCH] arm64: dts: visconti: Add watchdog support for TMPV7708 SoC

Nobuhiro Iwamatsu <[email protected]> writes:

> Add watchdog node in TMPV7708's dtsi, and tmpv7708-rm-mbrc boards's
> dts.
>
> Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> ---
> arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts | 5 +++++
> arch/arm64/boot/dts/toshiba/tmpv7708.dtsi | 12 ++++++++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> index ed0bf7f13f54..37da418393e0 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> @@ -41,3 +41,8 @@ &uart1 {
> clocks = <&uart_clk>;
> clock-names = "apb_pclk";
> };
> +
> +&wdt {
> + status = "okay";
> + clocks = <&wdt_clk>;
> +};
> diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> index 242f25f4e12a..c360e68bef1d 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> @@ -134,6 +134,12 @@ uart_clk: uart-clk {
> #clock-cells = <0>;
> };
>
> + wdt_clk: wdt-clk {
> + compatible = "fixed-clock";
> + clock-frequency = <150000000>;
> + #clock-cells = <0>;
> + };
> +
> soc {
> #address-cells = <2>;
> #size-cells = <2>;
> @@ -384,6 +390,12 @@ spi6: spi@28146000 {
> #size-cells = <0>;
> status = "disabled";
> };
> +
> + wdt: wdt@28330000 {
> + compatible = "toshiba,visconti-wdt";
> + reg = <0 0x28330000 0 0x1000>;
> + status = "disabled";
> + };
> };
> };

FWIW,

Reviewed-by: Punit Agrawal <[email protected]>

Thanks,
Punit