2017-12-01 19:23:18

by Eric Biggers

[permalink] [raw]
Subject: Re: 3239b6f29b ("KEYS: return full count in keyring_read() if buffer is too small"): ltp.keyctl06.fail

On Fri, Dec 01, 2017 at 10:40:12AM +0800, Fengguang Wu wrote:
> Hi Eric,
>
> We noticed LTP keyctl06 test regression in
>
> commit: 3239b6f29bdfb4b0a2ba59df995fc9e6f4df7f1f ("KEYS: return full count in keyring_read() if buffer is too small")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> on test machine: 48 threads Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz with 64G memory
> with following parameters:
>
> disk: 1HDD
> fs: ext4
> test: syscalls_part2
>
> test-description: The LTP testsuite contains a collection of tools for testing the Linux kernel and related features.
> test-url: http://linux-test-project.github.io/
>
> To reproduce:
>
> git clone https://github.com/intel/lkp-tests.git
> cd lkp-tests
> bin/lkp install job.yaml # job file is attached in this email
> bin/lkp run job.yaml
>
> testcase/path_params/tbox_group/run: ltp/1HDD-ext4-syscalls_part2/ivb44
>

Did this include LTP commit f21703fe45d3 ("syscalls/keyctl06: update to test for
follow-on fix")? It would be really helpful if these reports would include the
LTP commit that was used.

Eric


2017-12-05 09:43:14

by Richard Palethorpe

[permalink] [raw]
Subject: Re: [LTP] 3239b6f29b ("KEYS: return full count in keyring_read() if buffer is too small"): ltp.keyctl06.fail

Hello,

Eric Biggers writes:

> On Fri, Dec 01, 2017 at 10:40:12AM +0800, Fengguang Wu wrote:
>> Hi Eric,
>>
>> We noticed LTP keyctl06 test regression in
>>
>> commit: 3239b6f29bdfb4b0a2ba59df995fc9e6f4df7f1f ("KEYS: return full count in keyring_read() if buffer is too small")
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>>
>> on test machine: 48 threads Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz with 64G memory
>> with following parameters:
>>
>> disk: 1HDD
>> fs: ext4
>> test: syscalls_part2
>>
>> test-description: The LTP testsuite contains a collection of tools for testing the Linux kernel and related features.
>> test-url: http://linux-test-project.github.io/
>>
>> To reproduce:
>>
>> git clone https://github.com/intel/lkp-tests.git
>> cd lkp-tests
>> bin/lkp install job.yaml # job file is attached in this email
>> bin/lkp run job.yaml
>>
>> testcase/path_params/tbox_group/run: ltp/1HDD-ext4-syscalls_part2/ivb44
>>
>
> Did this include LTP commit f21703fe45d3 ("syscalls/keyctl06: update to test for
> follow-on fix")? It would be really helpful if these reports would include the
> LTP commit that was used.
>
> Eric

We are getting the following result, even with the follow up patch:

keyctl06.c:68: FAIL: KEYCTL_READ returned 4 but expected 8

This is with SUSE SLE15 kernel 4.12.14. I haven't had chance to
investigate it yet.

--
Thank you,
Richard.

2017-12-05 18:10:54

by Eric Biggers

[permalink] [raw]
Subject: Re: [LTP] 3239b6f29b ("KEYS: return full count in keyring_read() if buffer is too small"): ltp.keyctl06.fail

On Tue, Dec 05, 2017 at 10:43:08AM +0100, Richard Palethorpe wrote:
>
> We are getting the following result, even with the follow up patch:
>
> keyctl06.c:68: FAIL: KEYCTL_READ returned 4 but expected 8
>
> This is with SUSE SLE15 kernel 4.12.14. I haven't had chance to
> investigate it yet.
>

Does the kernel include *both* fixes the test tests for now?