2015-06-21 20:32:50

by Nicolai Stange

Subject: [PATCH] clocksource: stm32: introduce dependency on HAS_IOMEM

Fix allmodconfig compilation failer for ARCH=um:
drivers/clocksource/timer-stm32.c: In function 'stm32_clockevent_init':
drivers/clocksource/timer-stm32.c:175:2:
error: implicit declaration of function 'iounmap'
[-Werror=implicit-function-declaration]
iounmap(data->base);
^

Make CLKSRC_STM32 depend on HAS_IOMEM.

Signed-off-by: Nicolai Stange <[email protected]>
---
drivers/clocksource/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 60d7d3d..835e5c5 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -114,6 +114,7 @@ config CLKSRC_LPC32XX
config CLKSRC_STM32
bool "Clocksource for STM32 SoCs" if COMPILE_TEST
depends on OF
+ depends on HAS_IOMEM
select CLKSRC_MMIO

config ARM_ARCH_TIMER
--
2.4.4

2015-06-22 13:55:50

by Nicolai Stange

Subject: Re: [PATCH] clocksource: stm32: introduce dependency on HAS_IOMEM

Drop this patch.

1cb6c2151850 ("clocksource: Increase dependencies of timer-stm32 to
limit build wreckage")
from linux-next also fixes this, it introduces a dependency on ARM.

So, if you do not care about making the IOMEM dependency explicit,
forget about it.