The following changes since commit ec6931b281797b69e6cf109f9cc94d5a2bf994e0:
word-at-a-time: avoid undefined behaviour in zero_bytemask macro (2014-04-27 15:20:05 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus
for you to fetch changes up to 4982223e51e8ea9d09bb33c8323b5ec1877b2b51:
module: set nx before marking module MODULE_STATE_COMING. (2014-05-14 10:55:47 +0930)
----------------------------------------------------------------
Most of this is cleaning up various driver sysfs permissions so we can
re-add the perm check (we unified the module param and sysfs checks, but
the module ones were stronger so we weakened them temporarily).
Param parsing gets documented, and also "--" now forces args to be
handed to init (and ignored by the kernel).
Module NX/RO protections get tightened: we now set them before calling
parse_args().
Cheers,
Rusty.
----------------------------------------------------------------
Brian W Hart (1):
cpumask.h: silence warning with -Wsign-compare
Christian Engelmayer (1):
modpost: Fix resource leak in read_dump()
Rusty Russell (12):
param: hand arguments after -- straight to init
Documentation: Update kernel-parameters.tx
speakup: fix incorrect perms on speakup_acntsa.c
drivers/mtd/devices/docg3.c: avoid world-writable sysfs files.
drivers/video/fbdev/sm501fb.c: avoid world-writable sysfs files.
drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.
drivers/scsi/pm8001/pm8001_ctl.c: avoid world-writable sysfs files.
drivers/regulator/virtual: avoid world-writable sysfs files.
drivers/staging/speakup/: avoid world-writable sysfs files.
drivers/hid/hid-picolcd_fb: avoid world-writable sysfs files.
samples/kobject/: avoid world-writable sysfs files.
module: set nx before marking module MODULE_STATE_COMING.
Documentation/kernel-parameters.txt | 40 +++++++++++++--------
drivers/hid/hid-lg4ff.c | 2 +-
drivers/hid/hid-picolcd_fb.c | 2 +-
drivers/mtd/devices/docg3.c | 4 +--
drivers/regulator/virtual.c | 10 +++---
drivers/scsi/pm8001/pm8001_ctl.c | 2 +-
drivers/staging/speakup/kobjects.c | 62 ++++++++++++++++----------------
drivers/staging/speakup/speakup_acntpc.c | 14 ++++----
drivers/staging/speakup/speakup_acntsa.c | 22 ++++++------
drivers/staging/speakup/speakup_apollo.c | 16 ++++-----
drivers/staging/speakup/speakup_audptr.c | 16 ++++-----
drivers/staging/speakup/speakup_bns.c | 14 ++++----
drivers/staging/speakup/speakup_decext.c | 16 ++++-----
drivers/staging/speakup/speakup_decpc.c | 16 ++++-----
drivers/staging/speakup/speakup_dectlk.c | 16 ++++-----
drivers/staging/speakup/speakup_dtlk.c | 20 +++++------
drivers/staging/speakup/speakup_dummy.c | 14 ++++----
drivers/staging/speakup/speakup_keypc.c | 10 +++---
drivers/staging/speakup/speakup_ltlk.c | 20 +++++------
drivers/staging/speakup/speakup_soft.c | 22 ++++++------
drivers/staging/speakup/speakup_spkout.c | 16 ++++-----
drivers/staging/speakup/speakup_txprt.c | 14 ++++----
drivers/video/fbdev/sm501fb.c | 2 +-
include/linux/cpumask.h | 2 +-
include/linux/moduleparam.h | 2 +-
init/main.c | 33 ++++++++++++++---
kernel/module.c | 44 +++++++++++++----------
kernel/params.c | 25 +++++++------
samples/kobject/kobject-example.c | 7 ++--
samples/kobject/kset-example.c | 7 ++--
scripts/mod/modpost.c | 2 ++
On Wed, Jun 11, 2014 at 03:03:47PM +0930, Rusty Russell wrote:
> drivers/regulator/virtual: avoid world-writable sysfs files.
Acked-by: Mark Brown <[email protected]>
if you need to respin - please do send patches to maintainers.
Mark Brown <[email protected]> writes:
> On Wed, Jun 11, 2014 at 03:03:47PM +0930, Rusty Russell wrote:
>
>> drivers/regulator/virtual: avoid world-writable sysfs files.
>
> Acked-by: Mark Brown <[email protected]>
>
> if you need to respin - please do send patches to maintainers.
If the address in drivers/regulator/virtual.c is incorrect, please
update it:
Subject: [PATCH 5/9] drivers/regulator/virtual: avoid world-writable sysfs files.
To: [email protected]
Cc: Rusty Russell <[email protected]>, Mark Brown <[email protected]>
Date: Tue, 22 Apr 2014 13:03:28 +0930
In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.
Thanks,
Rusty.
On Thu, Jun 12, 2014 at 10:55:00AM +0930, Rusty Russell wrote:
> Mark Brown <[email protected]> writes:
> > if you need to respin - please do send patches to maintainers.
> If the address in drivers/regulator/virtual.c is incorrect, please
> update it:
> Subject: [PATCH 5/9] drivers/regulator/virtual: avoid world-writable sysfs files.
> To: [email protected]
> Cc: Rusty Russell <[email protected]>, Mark Brown <[email protected]>
> Date: Tue, 22 Apr 2014 13:03:28 +0930
The main people to hit are subsystem maintainers - driver authors have
often vanished or don't really respond to upstream e-mail, though of
course they should also be included.
Mark Brown <[email protected]> writes:
> On Thu, Jun 12, 2014 at 10:55:00AM +0930, Rusty Russell wrote:
>> Mark Brown <[email protected]> writes:
>
>> > if you need to respin - please do send patches to maintainers.
>
>> If the address in drivers/regulator/virtual.c is incorrect, please
>> update it:
>
>> Subject: [PATCH 5/9] drivers/regulator/virtual: avoid world-writable sysfs files.
>> To: [email protected]
>> Cc: Rusty Russell <[email protected]>, Mark Brown <[email protected]>
>> Date: Tue, 22 Apr 2014 13:03:28 +0930
> The main people to hit are subsystem maintainers - driver authors have
> often vanished or don't really respond to upstream e-mail, though of
> course they should also be included.
Fair enough. There's a limited amount of effort I go to in a sweep like
this, unless I'm really worried about a particular patch. lkml (used to
have?) a limit on how many people you could CC so I tend to trim.
So, did you queue a patch to fix your email address in
drivers/regulator/virtual.c?
Thanks.
Rusty.
On Fri, Jun 13, 2014 at 10:33:20AM +0930, Rusty Russell wrote:
> So, did you queue a patch to fix your email address in
> drivers/regulator/virtual.c?
No, that's more about giving credit to Wolfson for funding the code I
guess - it's very rare for anyone to update the author information (and
becoming more common for people to not put them in the file at all).
Everyone uses get_maintainers.pl these days, it'll do a reasonable first
pass at figuring out who's been working on the code and who the
subsystem maintainers are.
Hi Mark,
On Fri, Jun 13, 2014 at 11:24 AM, Mark Brown <[email protected]> wrote:
> On Fri, Jun 13, 2014 at 10:33:20AM +0930, Rusty Russell wrote:
>> So, did you queue a patch to fix your email address in
>> drivers/regulator/virtual.c?
>
> No, that's more about giving credit to Wolfson for funding the code I
> guess - it's very rare for anyone to update the author information (and
> becoming more common for people to not put them in the file at all).
> Everyone uses get_maintainers.pl these days, it'll do a reasonable first
> pass at figuring out who's been working on the code and who the
> subsystem maintainers are.
Still, obsolete email address are regularly updated or removed.
You can give credits in the comments. The file already has
Copyright 2008 Wolfson Microelectronics PLC.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds