2007-05-20 14:40:22

by OGAWA Hirofumi

[permalink] [raw]
Subject: [PATCH] Fix "fs: convert core functions to zero_user_page"


The bug introduced by 01f2705daf5a36208e69d7cf95db9c330f843af6.
It misses to convert the first argument, it should be "new_page".

This became the cause of fatfs corruption.

Cc: Nate Diller <[email protected]>
Signed-off-by: OGAWA Hirofumi <[email protected]>
---

fs/buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/buffer.c~fix-zero_user_page-conversion fs/buffer.c
--- linux-2.6/fs/buffer.c~fix-zero_user_page-conversion 2007-05-20 18:36:02.000000000 +0900
+++ linux-2.6-hirofumi/fs/buffer.c 2007-05-20 18:36:21.000000000 +0900
@@ -2109,7 +2109,7 @@ int cont_prepare_write(struct page *page
PAGE_CACHE_SIZE, get_block);
if (status)
goto out_unmap;
- zero_user_page(page, zerofrom, PAGE_CACHE_SIZE - zerofrom,
+ zero_user_page(new_page, zerofrom, PAGE_CACHE_SIZE - zerofrom,
KM_USER0);
generic_commit_write(NULL, new_page, zerofrom, PAGE_CACHE_SIZE);
unlock_page(new_page);
_

--
OGAWA Hirofumi <[email protected]>