2023-01-25 15:44:33

by Shuah Khan

Subject: [PATCH] docs: leds: fix the following docu build warning

Add leds-qcom-lpg to Documentation/leds/index.rst to fix the following
doc build warning.

Documentation/leds/leds-qcom-lpg.rst: WARNING: document isn't included in any toctree

Signed-off-by: Shuah Khan <[email protected]>
---
Documentation/leds/index.rst | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/leds/index.rst b/Documentation/leds/index.rst
index e5d63b940045..b9ca081fac71 100644
--- a/Documentation/leds/index.rst
+++ b/Documentation/leds/index.rst
@@ -26,3 +26,4 @@ LEDs
leds-lp55xx
leds-mlxcpld
leds-sc27xx
+ leds-qcom-lpg
--
2.34.1

2023-01-26 03:17:29

by Bagas Sanjaya

Subject: Re: [PATCH] docs: leds: fix the following docu build warning

On 1/25/23 22:44, Shuah Khan wrote:
> Add leds-qcom-lpg to Documentation/leds/index.rst to fix the following
> doc build warning.
>

The patch subject should have been "docs: leds: add missing documentation
to the toctree"

> Documentation/leds/leds-qcom-lpg.rst: WARNING: document isn't included in any toctree
>
> Signed-off-by: Shuah Khan <[email protected]>
> ---
> Documentation/leds/index.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/leds/index.rst b/Documentation/leds/index.rst
> index e5d63b940045..b9ca081fac71 100644
> --- a/Documentation/leds/index.rst
> +++ b/Documentation/leds/index.rst
> @@ -26,3 +26,4 @@ LEDs
> leds-lp55xx
> leds-mlxcpld
> leds-sc27xx
> + leds-qcom-lpg

Otherwise, LGTM.

Acked-by: Bagas Sanjaya <[email protected]>

--
An old man doll... just what I always wanted! - Clara

2023-01-26 14:37:43

by Jonathan Corbet

Subject: Re: [PATCH] docs: leds: fix the following docu build warning

Bagas Sanjaya <[email protected]> writes:

> On 1/25/23 22:44, Shuah Khan wrote:
>> Add leds-qcom-lpg to Documentation/leds/index.rst to fix the following
>> doc build warning.
>>
>
> The patch subject should have been "docs: leds: add missing documentation
> to the toctree"

Shuah has been doing this for a while and really does not need your
instructions on how to do a patch; this one is fine as-is.

Bagas, please stop harassing our contributors. I'm getting fairly tired
of asking that.

> Otherwise, LGTM.
>
> Acked-by: Bagas Sanjaya <[email protected]>

Do you have a history or status with the LED subsystem that puts you in
a position to ack this patch?

jon

2023-01-26 18:20:33

by Jonathan Corbet

Subject: Re: [PATCH] docs: leds: fix the following docu build warning

Shuah Khan <[email protected]> writes:

> Add leds-qcom-lpg to Documentation/leds/index.rst to fix the following
> doc build warning.
>
> Documentation/leds/leds-qcom-lpg.rst: WARNING: document isn't included in any toctree
>
> Signed-off-by: Shuah Khan <[email protected]>
> ---
> Documentation/leds/index.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/leds/index.rst b/Documentation/leds/index.rst
> index e5d63b940045..b9ca081fac71 100644
> --- a/Documentation/leds/index.rst
> +++ b/Documentation/leds/index.rst
> @@ -26,3 +26,4 @@ LEDs
> leds-lp55xx
> leds-mlxcpld
> leds-sc27xx
> + leds-qcom-lpg
> --

I've been meaning to fix this annoying warning for a long time, but
never got around to it. Applied, thanks!

jon