2021-06-07 02:41:26

by Zou Wei

[permalink] [raw]
Subject: [PATCH -next] net: dsa: hellcreek: Use is_zero_ether_addr() instead of memcmp()

Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/net/dsa/hirschmann/hellcreek.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
index 4d78219..9fdcc4b 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.c
+++ b/drivers/net/dsa/hirschmann/hellcreek.c
@@ -927,7 +927,6 @@ static int hellcreek_fdb_dump(struct dsa_switch *ds, int port,

/* Read table */
for (i = 0; i < hellcreek->fdb_entries; ++i) {
- unsigned char null_addr[ETH_ALEN] = { 0 };
struct hellcreek_fdb_entry entry = { 0 };

/* Read entry */
@@ -937,7 +936,7 @@ static int hellcreek_fdb_dump(struct dsa_switch *ds, int port,
hellcreek_write(hellcreek, 0x00, HR_FDBRDH);

/* Check valid */
- if (!memcmp(entry.mac, null_addr, ETH_ALEN))
+ if (is_zero_ether_addr(entry.mac))
continue;

/* Check port mask */
--
2.6.2


2021-06-07 05:45:11

by Kurt Kanzenbach

[permalink] [raw]
Subject: Re: [PATCH -next] net: dsa: hellcreek: Use is_zero_ether_addr() instead of memcmp()

On Mon Jun 07 2021, Zou Wei wrote:
> Using is_zero_ether_addr() instead of directly use
> memcmp() to determine if the ethernet address is all
> zeros.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Reviewed-by: Kurt Kanzenbach <[email protected]>


Attachments:
signature.asc (877.00 B)

2021-06-07 20:22:37

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH -next] net: dsa: hellcreek: Use is_zero_ether_addr() instead of memcmp()

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 7 Jun 2021 10:57:09 +0800 you wrote:
> Using is_zero_ether_addr() instead of directly use
> memcmp() to determine if the ethernet address is all
> zeros.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
>
> [...]

Here is the summary with links:
- [-next] net: dsa: hellcreek: Use is_zero_ether_addr() instead of memcmp()
https://git.kernel.org/netdev/net-next/c/3f07ce8e5287

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html