2018-01-23 16:06:33

by Gustavo A. R. Silva

[permalink] [raw]
Subject: [PATCH] USB: misc: chaoskey: Use true and false for boolean values

Assign true or false to boolean variables instead of an integer value.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/usb/misc/chaoskey.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/misc/chaoskey.c b/drivers/usb/misc/chaoskey.c
index b6a1b93..716cb51 100644
--- a/drivers/usb/misc/chaoskey.c
+++ b/drivers/usb/misc/chaoskey.c
@@ -183,10 +183,10 @@ static int chaoskey_probe(struct usb_interface *interface,
dev->in_ep = in_ep;

if (le16_to_cpu(udev->descriptor.idVendor) != ALEA_VENDOR_ID)
- dev->reads_started = 1;
+ dev->reads_started = true;

dev->size = size;
- dev->present = 1;
+ dev->present = true;

init_waitqueue_head(&dev->wait_q);

@@ -239,7 +239,7 @@ static void chaoskey_disconnect(struct usb_interface *interface)
usb_set_intfdata(interface, NULL);
mutex_lock(&dev->lock);

- dev->present = 0;
+ dev->present = false;
usb_poison_urb(dev->urb);

if (!dev->open) {
--
2.7.4



2018-01-23 21:08:48

by Keith Packard

[permalink] [raw]
Subject: Re: [PATCH] USB: misc: chaoskey: Use true and false for boolean values

"Gustavo A. R. Silva" <[email protected]> writes:

> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Reviewed-by: Keith Packard <[email protected]>

--
-keith


Attachments:
signature.asc (847.00 B)