2015-11-27 01:26:36

by Stephen Rothwell

Subject: linux-next: build failure after merge of the modules tree

Hi Rusty,

After merging the modules tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from include/linux/kexec.h:26:0,
from include/linux/crash_dump.h:5,
from arch/powerpc/platforms/powernv/pci-ioda.c:16:
include/linux/module.h:770:15: error: return type defaults to 'int' [-Werror=return-type]
static inline module_enable_ro(const struct module *mod) { }
^

and many many more of these :-(

Caused by commit

ccd6497a60e5 ("module: clean up RO/NX handling")

I have used the modules tree from next-20151126 for today.

--
Cheers,
Stephen Rothwell [email protected]

2015-11-27 03:49:46

by Rusty Russell

Subject: Re: linux-next: build failure after merge of the modules tree

Stephen Rothwell <[email protected]> writes:
> Hi Rusty,
>
> After merging the modules tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from include/linux/kexec.h:26:0,
> from include/linux/crash_dump.h:5,
> from arch/powerpc/platforms/powernv/pci-ioda.c:16:
> include/linux/module.h:770:15: error: return type defaults to 'int' [-Werror=return-type]

Thanks, this typo hit all archs which don't do RO module protection by
default.

Maybe PPC should do that?

I've fixed it (and some others found by 0-day) and rebased.

Thanks,
Rusty.