2023-12-19 00:26:41

by Jonathan Corbet

[permalink] [raw]
Subject: [PATCH] net: skbuff: Remove some excess struct-member documentation

Remove documentation for nonexistent structure members, addressing these
warnings:

./include/linux/skbuff.h:1063: warning: Excess struct member 'sp' description in 'sk_buff'
./include/linux/skbuff.h:1063: warning: Excess struct member 'nf_bridge' description in 'sk_buff'

Signed-off-by: Jonathan Corbet <[email protected]>
---
include/linux/skbuff.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 27998f73183e..1cdab90a10a2 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -742,7 +742,6 @@ typedef unsigned char *sk_buff_data_t;
* @dev_scratch: (aka @dev) alternate use of @dev when @dev would be %NULL
* @cb: Control buffer. Free for use by every layer. Put private vars here
* @_skb_refdst: destination entry (with norefcount bit)
- * @sp: the security path, used for xfrm
* @len: Length of actual data
* @data_len: Data length
* @mac_len: Length of link layer header
@@ -776,7 +775,6 @@ typedef unsigned char *sk_buff_data_t;
* @tcp_tsorted_anchor: list structure for TCP (tp->tsorted_sent_queue)
* @_sk_redir: socket redirection information for skmsg
* @_nfct: Associated connection, if any (with nfctinfo bits)
- * @nf_bridge: Saved data about a bridged frame - see br_netfilter.c
* @skb_iif: ifindex of device we arrived on
* @tc_index: Traffic control index
* @hash: the packet hash
--
2.43.0



2023-12-19 04:31:47

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] net: skbuff: Remove some excess struct-member documentation



On 12/18/23 16:26, Jonathan Corbet wrote:
> Remove documentation for nonexistent structure members, addressing these
> warnings:
>
> ./include/linux/skbuff.h:1063: warning: Excess struct member 'sp' description in 'sk_buff'
> ./include/linux/skbuff.h:1063: warning: Excess struct member 'nf_bridge' description in 'sk_buff'
>
> Signed-off-by: Jonathan Corbet <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>
Thanks.

> ---
> include/linux/skbuff.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 27998f73183e..1cdab90a10a2 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -742,7 +742,6 @@ typedef unsigned char *sk_buff_data_t;
> * @dev_scratch: (aka @dev) alternate use of @dev when @dev would be %NULL
> * @cb: Control buffer. Free for use by every layer. Put private vars here
> * @_skb_refdst: destination entry (with norefcount bit)
> - * @sp: the security path, used for xfrm
> * @len: Length of actual data
> * @data_len: Data length
> * @mac_len: Length of link layer header
> @@ -776,7 +775,6 @@ typedef unsigned char *sk_buff_data_t;
> * @tcp_tsorted_anchor: list structure for TCP (tp->tsorted_sent_queue)
> * @_sk_redir: socket redirection information for skmsg
> * @_nfct: Associated connection, if any (with nfctinfo bits)
> - * @nf_bridge: Saved data about a bridged frame - see br_netfilter.c
> * @skb_iif: ifindex of device we arrived on
> * @tc_index: Traffic control index
> * @hash: the packet hash

--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html

2023-12-22 23:20:55

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net: skbuff: Remove some excess struct-member documentation

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Mon, 18 Dec 2023 17:26:26 -0700 you wrote:
> Remove documentation for nonexistent structure members, addressing these
> warnings:
>
> ./include/linux/skbuff.h:1063: warning: Excess struct member 'sp' description in 'sk_buff'
> ./include/linux/skbuff.h:1063: warning: Excess struct member 'nf_bridge' description in 'sk_buff'
>
> Signed-off-by: Jonathan Corbet <[email protected]>
>
> [...]

Here is the summary with links:
- net: skbuff: Remove some excess struct-member documentation
https://git.kernel.org/netdev/net-next/c/dcc3e46472d6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html