2023-09-27 11:50:17

by Ritesh Harjani

[permalink] [raw]
Subject: Re: [PATCH v7 11/12] ext4: add first unit test for ext4_mb_new_blocks_simple in mballoc

Kemeng Shi <[email protected]> writes:

> Here are prepared work:
> 1. Include mballoc-test.c to mballoc.c to be able test static function
> in mballoc.c.
> 2. Implement static stub to avoid read IO to disk.
> 3. Construct fake super_block. Only partial members are set, more members
> will be set when more functions are tested.
> Then unit test for ext4_mb_new_blocks_simple is added.
>
> Signed-off-by: Kemeng Shi <[email protected]>
> ---
> fs/ext4/mballoc-test.c | 325 +++++++++++++++++++++++++++++++++++++++++
> fs/ext4/mballoc.c | 4 +
> 2 files changed, 329 insertions(+)
> create mode 100644 fs/ext4/mballoc-test.c

I guess I missed to add by RB in previous revision. I see there are no
functional changes to this patch from previous revision.

Please feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <[email protected]>

Thanks!
-ritesh